Missing Content-Disposition in raw_datastream view about eulfedora HOT 5 CLOSED

Thanks for reporting the issue. Somehow this use case hasn't come up for us, and I think we're generally setting download filenames in the django views that call raw_datastream.

The header will have to be pulled from the Fedora response and added to the HttpResponse that's created here:
https://github.com/emory-libraries/eulfedora/blob/master/eulfedora/views.py#L213

.. but getting the header from the Fedora response might be a little tricky since the code is currently using the DatastreamObject get_chunked_content method to avoid reading a whole datastream into memory at once. I presume the header you want is available on the response object returned by the api, but I don't see an obvious way to get it since get_chunked_content is a generator.

The best I can currently think of is to store relevant header information somewhere on the DatastreamObject so it can be picked up in the view. Hopefully we could store it in a more meaningful way rather than just "last datastream response headers". Thoughts?

from eulfedora.

It occurs to me that newer versions of Fedora than what we're currently running probably also provide additional information that's being calculated by the raw_datastream view, and if we could just pass them through that should be more efficient and accurate than handling them in eulfedora.

from eulfedora.

It just occurred to me that there is an easier way to fix this - rather than the view calling the DatastreamObject get_chunked_content method, it should just use the api getDatastreamDissemination method directly, which will return a response object that has all the headers as well as access to the content. I think that would actually be pretty straightforward.

@jrhoads do you want to try fixing this?

from eulfedora.

Thank You @rlskoeser
I will take a look at this on Monday.

from eulfedora.

@jrhoads Is this still an issue for you? And are you on Fedora 3.7 or later?

from eulfedora.