Git Product home page Git Product logo

Comments (4)

g-rden avatar g-rden commented on August 16, 2024 1

Understandable. I'll just keep it as a fork.

from darkhttpd.

hhartzer avatar hhartzer commented on August 16, 2024

This is pretty cool! I am curious if that works with Kodi. I would be happy to test that unless you happen to have Kodi ready to go.

I personally don't have any objections to that being the default, especially if it plays nicely with Kodi. I do think it'd be a great candidate for a couple of unit tests as well.

from darkhttpd.

g-rden avatar g-rden commented on August 16, 2024

I don't use kodi. Please test it if you want. If it shouldn't work then it might be able to make it compatible. Or just use the old way of displaying.

from darkhttpd.

emikulic avatar emikulic commented on August 16, 2024

I'm sorry but I'm not thrilled about this functionality. :( I think just showing the number of bytes is fine.

The Kodi regex (https://github.com/xbmc/xbmc/pull/17652/files) is ([0-9]+)(B|K|M|G)?(?=\\s|<|$) - IIUC it won't match GiB, so it's not clear if it's 1000 or 1024.

Off-topic: I personally would prefer thousands-separators like 123,456 except:

  • It's probably not worth the complexity
  • It breaks the Kodi regex (lol)
  • People are going to argue over , vs .

from darkhttpd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.