Options with only a part parenthesized isn't parsed about proto HOT 12 CLOSED

thank you for reporting this. I will include it in my tests and work on a fix

from proto.

I fixed the reported one but found another issue at line 115. I wonder whether the source is correct as the identifier has a whitespace between repeated and .min_items:

  repeated core.DataSource keys = 1 [(validate.rules).repeated .min_items = 1];
``

from proto.

if this is correct then should the first option be interpreted as (validate.rules).repeated = true ?

from proto.

These are very strange, where do people find out these weird strange cases on protobuf?
I don't really use envoy, I got this error while trying my library on all proto files I could find.
Maybe the protobuf BNF file can help?

from proto.

I found these options come from here:

https://github.com/lyft/protoc-gen-validate/blob/master/validate/validate.proto

But I don't see anything different in it than in other proto files...

from proto.

Someone pointed me to

https://developers.google.com/protocol-buffers/docs/reference/proto2-spec
https://developers.google.com/protocol-buffers/docs/reference/proto3-spec

it says

fieldOption = optionName "=" constant

Now, I am looking for the validate.proto to see it definition

from proto.

https://github.com/lyft/protoc-gen-validate/blob/master/validate/validate.proto

from proto.

In that definition, I read message RepeatedRules and based on this I conclude this is actually a syntax error on their part.

from proto.

(Removed the last comment, was an error on the proto file itself.)

from proto.

Other problem with this field:

Location home = 4 [(validate.rules).message.required = true];

The parser considers "message" a reserved word, but it isn't on this context.

2018/03/15 17:08:37 <input>:15:39: found "message" but expected [option postfix identifier]

from proto.

see #72 that fixes this too

from proto.

Seems fine to me!

from proto.