Comments (6)
This is not how the package works and thought of. Empty lines will disassociate the comment. Without this, many of our definitions will have wrong format ; e.g. syntax will have the copyright as its comment. Field comment will dangle.
Maybe this behavior can be made optional.
from proto.
This is how it is currently parsed, is what I am saying. Putting a newline does not disassociate the comment. In the above example, // bar
will be the Comment
field on Syntax
, and // baz
will be the Comment
on Package
. This is a bug if this is not how it should operate
from proto.
ok, i will review it again
from proto.
Hi, any status on this?
from proto.
ic, the comments should not be associated because they are separated. I created a test for this to fix.
from proto.
Your change here introduced a bug. Comments no longer appropriately associate.
$ cat yarpcproto/yarpc.proto
syntax = "proto3";
package uber.yarpc;
option go_package = "yarpcproto";
// Oneway is the return type to use for an rpc method if
// the method should be generated as oneway.
message Oneway {
bool ack = 1;
}
The comment on Oneway
is not associated with the *proto.Message
.
Can you please revert?
from proto.
Related Issues (20)
- Package name with "." causes issues when parsing HOT 1
- Issue with double-quoted options HOT 1
- Quote dropped in option parsing
- Missing semicolon at end silently ignored. HOT 1
- Quoted string constant
- Multi-line fields not parseable
- QuoteRune is a breaking change HOT 4
- Write proto struct to file? HOT 1
- Comments inside field options break parser HOT 2
- Nested enum with inline comments break parser HOT 5
- Infinite loop in Parser.Parse() HOT 2
- Sir, if I get the package field? HOT 3
- support proto3 presence HOT 1
- Field type with keyword is not correctly parsed HOT 3
- Option string values parsed as numbers HOT 8
- embedded comment parse fail HOT 7
- Parse failure on negative reserved enums HOT 4
- Boolean variable to test if a field is deprecated HOT 11
- Parsing comments inside an array in an Option HOT 4
- EnumField does not implement elementContainer and so its Elements are missed in Walk HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proto.