Git Product home page Git Product logo

Comments (6)

emicklei avatar emicklei commented on June 12, 2024

This is not how the package works and thought of. Empty lines will disassociate the comment. Without this, many of our definitions will have wrong format ; e.g. syntax will have the copyright as its comment. Field comment will dangle.
Maybe this behavior can be made optional.

from proto.

bufdev avatar bufdev commented on June 12, 2024

This is how it is currently parsed, is what I am saying. Putting a newline does not disassociate the comment. In the above example, // bar will be the Comment field on Syntax, and // baz will be the Comment on Package. This is a bug if this is not how it should operate

from proto.

emicklei avatar emicklei commented on June 12, 2024

ok, i will review it again

from proto.

bufdev avatar bufdev commented on June 12, 2024

Hi, any status on this?

from proto.

emicklei avatar emicklei commented on June 12, 2024

ic, the comments should not be associated because they are separated. I created a test for this to fix.

from proto.

bufdev avatar bufdev commented on June 12, 2024

Your change here introduced a bug. Comments no longer appropriately associate.

$ cat yarpcproto/yarpc.proto
syntax = "proto3";

package uber.yarpc;

option go_package = "yarpcproto";

// Oneway is the return type to use for an rpc method if
// the method should be generated as oneway.
message Oneway {
  bool ack = 1;
}

The comment on Oneway is not associated with the *proto.Message.

Can you please revert?

from proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.