Git Product home page Git Product logo

Comments (5)

emiago avatar emiago commented on August 28, 2024

I would not go with this func. I would still like to know some use case of changing this values from default one?
Exposing just with var for me is enough, if someone needs to change one timer, he should look others as well.

from sipgo.

a12n avatar a12n commented on August 28, 2024

I would still like to know some use case of changing this values from default one?

T1 is an estimate of RTT and it should be quite different when you connect to a node in the same data center or to a node on another continent. In the former case it should retry (and eventually fail and do failover) much earlier.

It's not that important for my current project, where I'm trying to go with sipgo. 500 ms is OK in this case. But there might be cases when it's a big deal.

I would not go with this func.

Yeah, it doesn't look nice. I just can't come up with a better way now. Maybe, introducing more ClientRequestOption for timers will be better.

from sipgo.

emiago avatar emiago commented on August 28, 2024

thnx for sharing. Sure T1 is most important. So it is more I want to change T1 and let others be populated.

Maybe we can have this to be populated on package level
SetT1 SetT2 etc..

Let me know would this be enough. We can always export all timers, but maybe for now keeping package API small?

from sipgo.

emiago avatar emiago commented on August 28, 2024

This waits too long. Adding priority

from sipgo.

emiago avatar emiago commented on August 28, 2024

@a12n was delayed, but done.

from sipgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.