Comments (5)
sandstrom
commented on September 17, 2024
1
I'm doing some issue gardening 🌱🌿 🌷 and came upon this issue. Since it's quite old I just wanted to ask if this is still relevant? If it isn't, maybe we can close this issue?
By closing some old issues we reduce the list of open issues to a more manageable set.
Since ember-decorators was an exploratory package, and most of it was upstreamed into Ember, maybe this isn't as relevant today.
from embroider.
stefanpenner
commented on September 17, 2024
What lead me here was the following error:
Build Error (OneShot)
Build Canceled: Broccoli Builder ran into an error with `RewritePackageJSON` plugin. 💥
Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators'
```
=================================================================================
ENV Summary:
TIME: Tue Mar 05 2019 14:54:38 GMT-0800 (Pacific Standard Time)
TITLE: ember
ARGV:
- /Users/spenner/.gradle/pemberly/node-v10.6.0-darwin-x64/bin/node
- /Users/spenner/.config/node/default/bin/ember
- b
- --app=extended
EXEC_PATH: /Users/spenner/.gradle/pemberly/node-v10.6.0-darwin-x64/bin/node
TMPDIR: /var/folders/4r/whc65vwj1xggvvky3yy1cp9m000mw4/T
SHELL: /usr/local/bin/fish
PATH: - /Users/spenner/.gradle/pemberly/yarnpkg-1.13.0/bin
- /Users/spenner/.gradle/pemberly/node-v10.6.0-darwin-x64/bin
- /Users/spenner/l/pemberly-example-web_trunk/.gradle/pemberly
- /Users/spenner/.cargo/bin
- /Users/spenner/.fzf/bin
- /Users/spenner/.local/bin
- /Applications/Racket v7.1/bin/
- /Users/spenner/.config/node/default/bin
- /usr/local/bin
- /usr/bin
- /bin
- /usr/sbin
- /sbin
- /usr/local/linkedin/bin
- /Applications/VMware
- Fusion.app/Contents/Public
- /export/content/linkedin/bin
- /Applications/Wireshark.app/Contents/MacOS
PLATFORM: darwin x64
FREEMEM: 268320768
TOTALMEM: 17179869184
UPTIME: 90993
LOADAVG: 1.69677734375,1.9775390625,2.0810546875
CPUS: - Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
- Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz - 3100
ENDIANNESS: LE
VERSIONS: - ares: 1.14.0
- cldr: 33.0
- http_parser: 2.8.0
- icu: 61.1
- modules: 64
- napi: 3
- nghttp2: 1.32.0
- node: 10.6.0
- openssl: 1.1.0h
- tz: 2018c
- unicode: 10.0
- uv: 1.21.0
- v8: 6.7.288.46-node.13
- zlib: 1.2.11
ERROR Summary:
- broccoliBuilderErrorStack: Error: Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators'
at Function.module.exports [as sync] (/Users/spenner/src/embroider-build/embroider/node_modules/resolve/lib/sync.js:58:15)
at get_or_create_1.getOrCreate (/Users/spenner/src/embroider-build/embroider/packages/core/src/package-cache.js:20:57)
at Object.getOrCreate (/Users/spenner/src/embroider-build/embroider/packages/core/src/get-or-create.js:6:18)
at MovablePackageCache.resolve (/Users/spenner/src/embroider-build/embroider/packages/core/src/package-cache.js:19:32)
at names.map.name (/Users/spenner/src/embroider-build/embroider/packages/core/src/package.js:78:56)
at Array.map ()
at TweakedPackage.get dependencies (/Users/spenner/src/embroider-build/embroider/packages/core/src/package.js:78:26)
at TweakedPackage. (/Users/spenner/src/embroider-build/embroider/node_modules/typescript-memoize/dist/memoize-decorator.js:67:52)
at DependencyAnalyzer.get externals [as externals] (/Users/spenner/src/embroider-build/embroider/packages/compat/src/dependency-analyzer.js:26:34)
at RewritePackageJSON.build (/Users/spenner/src/embroider-build/embroider/packages/compat/src/rewrite-package-json.js:30:40)
at /Users/spenner/src/embroider-build/embroider/node_modules/broccoli-plugin/read_compat.js:93:34
at tryCatch (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:525:12)
at invokeCallback (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:538:13)
at publish (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:508:7)
at flush (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:2415:5)
at process._tickCallback (internal/process/next_tick.js:61:11) - code: [undefined]
- codeFrame: Build Canceled: Broccoli Builder ran into an error with
RewritePackageJSONplugin. 💥
Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators' - errorMessage: Build Canceled: Broccoli Builder ran into an error with
RewritePackageJSONplugin. 💥
Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators'
at OneShot
-- created here: --
at new Plugin (/Users/spenner/src/embroider-build/embroider/node_modules/broccoli-plugin/index.js:7:31)
at new OneShot (/Users/spenner/src/embroider-build/embroider/packages/compat/src/one-shot.js:14:9)
at Object.cachedBuildCompatAddon [as default] (/Users/spenner/src/embroider-build/embroider/packages/compat/src/build-compat-addon.js:15:16)
at CompatAddons.movedAddons.map.oldPkg (/Users/spenner/src/embroider-build/embroider/packages/compat/src/compat-addons.js:33:105)
at Array.map ()
at new CompatAddons (/Users/spenner/src/embroider-build/embroider/packages/compat/src/compat-addons.js:33:63)
at Object.defaultPipeline [as compatBuild] (/Users/spenner/src/embroider-build/embroider/packages/compat/src/default-pipeline.js:11:18)
at module.exports (/Users/spenner/l/pemberly-example-web_trunk/ember-cli-build.js:64:39)
at Builder.readBuildFile (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/builder.js:52:14)
at Builder.setupBroccoliBuilder (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/builder.js:66:22)
at new Builder (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/builder.js:32:10)
at BuildTask.run (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/tasks/build.js:15:19)
at Promise.resolve.then (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/command.js:243:46)
at tryCatcher (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:323:19)
at invokeCallback (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:495:31)
at /Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:559:14
at flush (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:2402:5)
at process._tickCallback (internal/process/next_tick.js:61:11)
at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
at startup (internal/bootstrap/node.js:236:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:560:3)
-- (end) -- - errorType: Build Error
- location:
- column: [undefined]
- file: [undefined]
- line: [undefined]
- treeDir: [undefined]
- message: Build Canceled: Broccoli Builder ran into an error with
RewritePackageJSONplugin. 💥
Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators'
at OneShot
-- created here: --
at new Plugin (/Users/spenner/src/embroider-build/embroider/node_modules/broccoli-plugin/index.js:7:31)
at new OneShot (/Users/spenner/src/embroider-build/embroider/packages/compat/src/one-shot.js:14:9)
at Object.cachedBuildCompatAddon [as default] (/Users/spenner/src/embroider-build/embroider/packages/compat/src/build-compat-addon.js:15:16)
at CompatAddons.movedAddons.map.oldPkg (/Users/spenner/src/embroider-build/embroider/packages/compat/src/compat-addons.js:33:105)
at Array.map ()
at new CompatAddons (/Users/spenner/src/embroider-build/embroider/packages/compat/src/compat-addons.js:33:63)
at Object.defaultPipeline [as compatBuild] (/Users/spenner/src/embroider-build/embroider/packages/compat/src/default-pipeline.js:11:18)
at module.exports (/Users/spenner/l/pemberly-example-web_trunk/ember-cli-build.js:64:39)
at Builder.readBuildFile (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/builder.js:52:14)
at Builder.setupBroccoliBuilder (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/builder.js:66:22)
at new Builder (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/builder.js:32:10)
at BuildTask.run (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/tasks/build.js:15:19)
at Promise.resolve.then (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/lib/models/command.js:243:46)
at tryCatcher (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:323:19)
at invokeCallback (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:495:31)
at /Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:559:14
at flush (/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:2402:5)
at process._tickCallback (internal/process/next_tick.js:61:11)
at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
at startup (internal/bootstrap/node.js:236:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:560:3)
-- (end) -- - name: BuildError
- nodeAnnotation: [undefined]
- nodeName: OneShot
- originalErrorMessage: Build Canceled: Broccoli Builder ran into an error with
RewritePackageJSONplugin. 💥
Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators' - stack: Error: Cannot find module 'ember-data/package.json' from '/Users/spenner/l/pemberly-example-web_trunk/node_modules/ember-decorators'
at Function.module.exports [as sync] (/Users/spenner/src/embroider-build/embroider/node_modules/resolve/lib/sync.js:58:15)
at get_or_create_1.getOrCreate (/Users/spenner/src/embroider-build/embroider/packages/core/src/package-cache.js:20:57)
at Object.getOrCreate (/Users/spenner/src/embroider-build/embroider/packages/core/src/get-or-create.js:6:18)
at MovablePackageCache.resolve (/Users/spenner/src/embroider-build/embroider/packages/core/src/package-cache.js:19:32)
at names.map.name (/Users/spenner/src/embroider-build/embroider/packages/core/src/package.js:78:56)
at Array.map ()
at TweakedPackage.get dependencies (/Users/spenner/src/embroider-build/embroider/packages/core/src/package.js:78:26)
at TweakedPackage. (/Users/spenner/src/embroider-build/embroider/node_modules/typescript-memoize/dist/memoize-decorator.js:67:52)
at DependencyAnalyzer.get externals [as externals] (/Users/spenner/src/embroider-build/embroider/packages/compat/src/dependency-analyzer.js:26:34)
at RewritePackageJSON.build (/Users/spenner/src/embroider-build/embroider/packages/compat/src/rewrite-package-json.js:30:40)
at /Users/spenner/src/embroider-build/embroider/node_modules/broccoli-plugin/read_compat.js:93:34
at tryCatch (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:525:12)
at invokeCallback (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:538:13)
at publish (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:508:7)
at flush (/Users/spenner/src/embroider-build/embroider/node_modules/rsvp/dist/rsvp.js:2415:5)
at process._tickCallback (internal/process/next_tick.js:61:11)
=================================================================================
</detais>
from embroider.
ef4
commented on September 17, 2024
Yeah, sorry about that, some of these adapters are very blunt and date to when I was just trying to get the first end-to-end builds to succeed.
I think the latest versions of ember-decorators may have addressed this upstream anyway. The ember-data decorators are in their own @ember-decorators/data addon, which can be added and removed independently of the others.
Also, even if this kind of compat adapter is still needed we could do it better now using the macro system, by wrapping the offending module in macroIf(dependencySatisfies('ember-data', '*'), ...).
I think this problem also solves itself when the staticAddonTrees optimization is enabled. With that flag, we won't traverse into the modules in ember-decorators that depend on ember-data unless your app explicitly depends on them. It makes everything necessarily paygo.
As a workaround, you can disable the built-in compat adapter by setting
require('@embroider/compat').compatBuild(app, Webpack, {
compatAdapters: new Map([['ember-decorators', null]])
});from embroider.
stefanpenner
commented on September 17, 2024
Yeah, sorry about that, some of these adapters are very blunt and date to when I was just trying to get the first end-to-end builds to succeed.
It was a fun debugging, thanks for leaving me the treasure hunt ;)
from embroider.
stefanpenner
commented on September 17, 2024
As a workaround, you can disable the built-in compat adapter by setting
Awesome thanks, I was just commenting out the code in embroider, but this will be more sustainable.
from embroider.
Related Issues (20)
- FastBoot + Embroider + browser-only library issue HOT 2
- Invalid code output when using `@embroider/macros` (ember app) HOT 2
- Libraries cannot import virtrual files generated from unplugin HOT 3
- [main + v3]: Resolver does not allow plugins which have virtual modules that import their own (library's) virtual modules HOT 7
- components in v2 addon's app-js using index files broken HOT 5
- "Scenario embroider-optimized: FAIL" seen when using index components in tests HOT 2
- [main + v3, webpack]: Resolver is not compatible with virtual files which import from the app HOT 2
- Module not found: Error: Can't resolve './-private/function-based/modifier-manager' HOT 1
- importSync error: `Expected identifier but found "*"` when using the `@cached` decorator in `ember-headless-table` with `@embroider/vite` HOT 1
- V1 addon (TypeScript) with app/components/some-component.ts fails to find the component HOT 3
- Tracking issue for breaking changes in 4.x
- Module not found: `Error: Can't resolve './helpers/liquid-outlet'` & CSS import into `app.ts`
- Ability to control order of addon implicit styles? HOT 1
- Can a compat app keep all of the unprocessed app/styles/ files? HOT 1
- `{{unique-id}}` helper is broken in 3.4.8 HOT 10
- How do you watch addon changes / rebuilds under embroider? HOT 6
- Build times out on CI only HOT 3
- @embroider/addon-dev: co-located components run through babel too late, resulting in the template-part to not be able to be compiled to wire format HOT 3
- Regression on app-js order/shadowing HOT 2
- embroider @ v3 is not compatible with explicit babel config w/ ember-cli-babel HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from embroider.