Git Product home page Git Product logo

Comments (3)

ef4 avatar ef4 commented on August 13, 2024

Yes. I'm pretty sure non-lazy engines are already supported.

For lazy-engines, I think they technically already work (meaning nothing actually breaks), but everything imported from the lazy engine would end up in vendor.js, so would not be lazy.

Fixing this is probably not very hard. Right now, we pick one package (meaning an app or addon) that is using ember-auto-import to be the primary and actually do the bundling. All the others that are using ember-auto-import just hook their source trees into the primary's import analyzer.

Instead of picking a single global primary, each package should look upward through its ancestor packages and stop when it finds a lazy engine, and only share the bundler within the engine.

from ember-auto-import.

ef4 avatar ef4 commented on August 13, 2024

While I would still like to fix this issue directly, a workaround is now available. Lazy engines can use dynamic import() to lazily load their own dependencies.

from ember-auto-import.

NullVoxPopuli avatar NullVoxPopuli commented on August 13, 2024

Hello! we're doing some issue triage and wanted to provide resolution to various issues, and provide closure for some issue, or confirm that they are still a problem, and that we haven't forgotten.

For lazy engines, they are supported under embroider, here is an example test, using a lazy engine

In ember-auto-import, the issue could still be present (as it is now 5 years later), and it would be fantastic to have a PR for a failing test scenario (maybe even copying from the embroider test!).

Thank you!!

from ember-auto-import.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.