Comments (3)
Yes. I'm pretty sure non-lazy engines are already supported.
For lazy-engines, I think they technically already work (meaning nothing actually breaks), but everything imported from the lazy engine would end up in vendor.js
, so would not be lazy.
Fixing this is probably not very hard. Right now, we pick one package (meaning an app or addon) that is using ember-auto-import to be the primary and actually do the bundling. All the others that are using ember-auto-import just hook their source trees into the primary's import analyzer.
Instead of picking a single global primary, each package should look upward through its ancestor packages and stop when it finds a lazy engine, and only share the bundler within the engine.
from ember-auto-import.
While I would still like to fix this issue directly, a workaround is now available. Lazy engines can use dynamic import()
to lazily load their own dependencies.
from ember-auto-import.
Hello! we're doing some issue triage and wanted to provide resolution to various issues, and provide closure for some issue, or confirm that they are still a problem, and that we haven't forgotten.
For lazy engines, they are supported under embroider, here is an example test, using a lazy engine
In ember-auto-import, the issue could still be present (as it is now 5 years later), and it would be fantastic to have a PR for a failing test scenario (maybe even copying from the embroider test!).
Thank you!!
from ember-auto-import.
Related Issues (20)
- Cannot find require and module definitions when upgrading to v2 HOT 1
- `instanceof` fails in classic mode HOT 4
- css imports not working until referenced
- Embroider app doesn't detect runtime changes of v2 addon HOT 1
- Transitive Dependency Resolution Breaks Build on Recursive v2 Addons HOT 2
- "Require is not defined" HOT 1
- Add polyfill use case to FAQ HOT 4
- Dynamic import missing fingerprint URL HOT 1
- Add option to disable decorator transforms in case we are using a different decorator transform plugin HOT 1
- Importing does not work HOT 7
- Error loading fingerprinted lazy engine assets after moving to ember-auto-import v2 HOT 1
- "import * as ... from ..." syntax breaks when upgrading from ember-auto-import 2.6.3 to 2.7.2 HOT 2
- issue with gts/gjs if ts transform is enabled HOT 13
- error after ember upgrade - Module not found: Error: Can't resolve 'ember-qunit/qunit-module' HOT 2
- Strange import behavior with pdfjs v4 HOT 2
- `allowAppImports` entries are now allowed to import from other `allowAppImports` entries. HOT 4
- No AMD shim when alias is referencing absolute path
- Virtual modules from plugins are not importable
- Cannot dynamically import a component with `allowAppImports`
- v2 addons are not bundled when listed in dependencies of lazy-loading engine (weirdo fix attached)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-auto-import.