Git Product home page Git Product logo

Comments (16)

benatkin avatar benatkin commented on May 14, 2024

Oh BTW think of this as a pull request for github metadata. I didn't mean to sound any more direct than that. :)

from ember-rails.

keithpitt avatar keithpitt commented on May 14, 2024

Yeah, @wycats needs to update that for me :)

from ember-rails.

benatkin avatar benatkin commented on May 14, 2024

@keithpitt maybe it's because it doesn't work with Rails 3.2?

Just kidding. Most of the apps that people claimed didn't work with Rails 3.1 actually did because the asset pipeline is optional. I wish more programmers cared about the accuracy of their statements. Heh.

from ember-rails.

keithpitt avatar keithpitt commented on May 14, 2024

ember-rails works with both Rails 3.1 & 3.2. But it uses the asset pipeline. It works the same was a jquery-rails does. Who are these people that claim it doesn't work? Perhaps I need to enlighten them.

from ember-rails.

benatkin avatar benatkin commented on May 14, 2024

I wasn't talking about ember-js in reference to Rails 3.1...I was just saying that compatibility across Rails 3.x isn't as brittle as people claim. But next time I see someone bitching about how Rails 3.1 (and not the asset pipeline) broke their app I'll be sure to say something.

from ember-rails.

keithpitt avatar keithpitt commented on May 14, 2024

Ah right, sorry I misunderstood. It thought you mean't people were talking about ember-js :D

It'd be nice for me to somehow mark a gem as being "asset pipeline" required. So if you include it in your gem, your server won't start up with an error "Rails pipeline is necessary for this..." or something like that.

from ember-rails.

mmacedo avatar mmacedo commented on May 14, 2024

The gemspec tells yet another thing (it is code, so it is the truth or it is a bug):

s.add_dependency "railties", [">= 3.0"]

s.add_development_dependency "rails", [">= 3.0"]

from ember-rails.

mmacedo avatar mmacedo commented on May 14, 2024

Would be nice to normalize all the 3.x too, I think it infers that it works on any Rails 3 version (not what other descriptions say).

from ember-rails.

tchak avatar tchak commented on May 14, 2024

I fixed dependency to require rails ~> 3.1
Changed README to 3.1+

from ember-rails.

wagenet avatar wagenet commented on May 14, 2024

@tchak Can we close this then?

from ember-rails.

benatkin avatar benatkin commented on May 14, 2024

You could change it to 3.1+ in the repository description, too (GitHub metadata). But other than that it looks like it's fixed.

from ember-rails.

tchak avatar tchak commented on May 14, 2024

I do not have acces to repository metadata, this is why I did not close it. @wagenet can you change the repo description and the link?

from ember-rails.

benatkin avatar benatkin commented on May 14, 2024

Ah, didn't even notice that the link pointed to the wrong GitHub Pages. Doesn't seem quite so frivolous suggesting it be changed. :)

from ember-rails.

tchak avatar tchak commented on May 14, 2024

We also need to change the link on rubygems.org page

from ember-rails.

wagenet avatar wagenet commented on May 14, 2024

I've changed the repo description. I don't think I have access to the gem.

from ember-rails.

tchak avatar tchak commented on May 14, 2024

Link on the rubygems site fixed

from ember-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.