Comments (3)
Following up on discussion with @chancancode to capture some pieces we figured out:
- This isn't necessarily a concern of
ember-optional-features
, which was intended to be used by app consumers - Addons don't generally have template-only components if they are following the re-export pattern in their app/ directory
- This codemod is necessary for addons that expect to use Wall St syntax for namespaced component invocation (and will be useful for template imports as well)
Conclusion: It may be better for this codemod to live as a separate project in ember-codemods
rather than as part of this project.
from ember-optional-features.
Coming full circle on this.
@rwjblue implemented the codemod to fix this here: rwjblue/ember-holy-futuristic-template-namespacing-batman-codemod#58
However, there is a related issue that I believe does impact this project. If you enable template-only-glimmer-components
in an addon, it does not create backing classes for template-only components in tests/dummy/templates/components
, which is a perfectly valid use-case for addons.
from ember-optional-features.
which is a perfectly valid use-case for addons
Ya, agreed.
from ember-optional-features.
Related Issues (19)
- Flesh out README HOT 3
- Expose a module for runtime detection of opt-in/opt-out. HOT 5
- Feature option is not being reflected when app renders HOT 8
- more information rfc link results in 404 HOT 1
- feature:enable, feature:disable commands update the optional-fatures.js file thus replacing existing key:value with new ones. May want to append to the file, rather than replace/update. HOT 3
- How do enable it inside an in-repo-addon? HOT 2
- Tests fail with latest version of ember-cli-version-checker HOT 1
- [template-only-glimmer-components]: TS component modules are ignored during installation
- Support reading options from process.env HOT 9
- Detect from dummy app's config when locally developing addons.
- How to hide deprecation warning in addons
- Handle Colocated template only components HOT 2
- Backport `isFeatureEnabled` to older version(s)
- Add `jquery-integration` feature to known features list... HOT 1
- Convert to TS or supply ambient definitions
- Support pods HOT 2
- Enable command is destructive in an addon HOT 1
- Support prototype extensions flag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-optional-features.