Git Product home page Git Product logo

Comments (3)

elwayman02 avatar elwayman02 commented on August 22, 2024

Following up on discussion with @chancancode to capture some pieces we figured out:

  • This isn't necessarily a concern of ember-optional-features, which was intended to be used by app consumers
  • Addons don't generally have template-only components if they are following the re-export pattern in their app/ directory
  • This codemod is necessary for addons that expect to use Wall St syntax for namespaced component invocation (and will be useful for template imports as well)

Conclusion: It may be better for this codemod to live as a separate project in ember-codemods rather than as part of this project.

from ember-optional-features.

elwayman02 avatar elwayman02 commented on August 22, 2024

Coming full circle on this.

@rwjblue implemented the codemod to fix this here: rwjblue/ember-holy-futuristic-template-namespacing-batman-codemod#58

However, there is a related issue that I believe does impact this project. If you enable template-only-glimmer-components in an addon, it does not create backing classes for template-only components in tests/dummy/templates/components, which is a perfectly valid use-case for addons.

from ember-optional-features.

rwjblue avatar rwjblue commented on August 22, 2024

which is a perfectly valid use-case for addons

Ya, agreed.

from ember-optional-features.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.