Breaks on ember 5.2 w/ staticEmberSource: true about ember-inspector HOT 17 CLOSED

It looks like all computed.x are undefined at that point?
I'm also on 5.2 and it's working... is that always happening or does it work sometimes after a few refresh?
Maybe something special with your setup?
Is that a public repo that we can test on? Edit: yes, it is :)
It looks like ember did not fully boot and ember debug already loads. Though i fixed that some time ago, so i might have a look at this

from ember-inspector.

Ah, probably because of staticEmberSource.
There is also an issue over at embroider

from ember-inspector.

I thought the ember inspector uses its own ember-source 🤔 I guess -- why does it care about if I've svelte'd away parts of ember-source or not?

from ember-inspector.

Nope, the ember_debug part relies on the apps ember source.
Probably to minimize size?
But it should definitely be possible now. If we can make a static build of ember_debug witn static ember source.

from ember-inspector.

You could adda file like this to your project

import * as runloop from '@ember/runloop';
import * as compued from '@ember/computed';
define('@ember/runloop', () => runloop);
define('@ember/conputed', () => conputed);

Would need more defines ofc.

I have this on my work pc. Will post it tomorrow:)

from ember-inspector.

It needs to use the app's Ember because it lives alongside the app and is used to debug apps. It wouldn't make sense to drop in a way different version of Ember and expect the ember_debug side of things to work, as your app uses what it uses.

from ember-inspector.

@RobbieTheWagner is the access of computed stuff needed? I would expect that If I (and none of my addons) use computed.readonly, that it wouldn't be in the build -- how should the inspector handle this scenario?

from ember-inspector.

@RobbieTheWagner is the access of computed stuff needed? I would expect that If I (and none of my addons) use computed.readonly, that it wouldn't be in the build -- how should the inspector handle this scenario?

Even if ember_debug uses as much as possible of ember directly. There will be some parts that it needs from the app itself.

Embroider should probably have a inspector compat mode.

from ember-inspector.

I think we need to update our shim in ember_debug that finds the computed modules to import each one individually https://github.com/emberjs/ember-inspector/blob/main/ember_debug/utils/ember/object/computed.js#L11

from ember-inspector.

It doesn't matter , they are not in the module because of dead code elimination

from ember-inspector.

It doesn't matter , they are not in the module because of dead code elimination

Ohhh, I understand now. This is an error because it was stripped from Ember, not because we're using it from a deprecated place. That is indeed tricky. We probably do need some kind of Embroider adapter that will put back the things we need.

from ember-inspector.

@NullVoxPopuli
this is what i have in my app to get inspector to start

import * as computed from '@ember/object/computed';
import * as runloop from '@ember/runloop';
import * as metal from '@ember/-internals/metal';
import * as inst from '@ember/instrumentation';
import * as view from '@ember/-internals/views';
import * as ref from '@glimmer/reference';
import * as val from '@glimmer/validator';
import ember from 'ember';
define('ember', [], () => ember);
define('@ember/object/computed', [], () => computed);
define('@ember/runloop', [], () => runloop);
define('@ember/-internals/metal', [], () => metal);
define('@ember/instrumentation', [], () => inst);
define('@ember/-internals/views', [], () => view);
define('@glimmer/reference', [], () => ref);
define('@glimmer/validator', [], () => val);

from ember-inspector.

that makes my app bigger tho

from ember-inspector.

Probably importing ember is the culprit.
Will it be smaller if that is removed.
I think there we could probably to remove that usage if specific imports are available

from ember-inspector.

This should probably be a build time thing with embroider etc. Like all of the things should be shipped for inspector to work in dev mode at least. If you want to opt out in production, that is fine.

from ember-inspector.

I think all of those required things are actually in your app. But just not exposed

from ember-inspector.

What if the inspector just doesn't access things that aren't available?

A graceful degradation (with messaging) sort of behavior?

from ember-inspector.