Comments (10)
should be resolved on main. Will result in the module still being present unfortunately, though empty.
from data.
hrm, this one is kinda tricky because I don't think we can safely add it as an app re-export and support configuring it correctly. With it being a v2-addon now its likely you should have to explicitly add it to your build.
from data.
the v2 addons do have app re exports with the provided rollup addons from embroider.
Can you not use those?
from data.
Hey @patricklx if you can point me to that I can spend some1 time adding those if you ok with it @runspired
from data.
Sure. It's in the default blueprint:
https://github.com/embroider-build/addon-blueprint/blob/cb4d7eee319b15cd2aae822653009a96d10baab4/files/__addonLocation__/rollup.config.mjs#L29
from data.
I think it should have at least a deprecate step. So it could also be part of -ember-data package. With some macro condition?
https://github.com/emberjs/data/tree/main/packages/-ember-data/app
from data.
We can't use app re-export from the V2 add-on at all, we could maybe guard the import in -ember-data but regardless we'll have to break the existing config setting
from data.
Why not? Some constraints by ember data internals?
from data.
@patricklx because we have an existing config setting used to keep it in the build in v1, the default is that its not included in the build, and vite/embroider don't have a clean production-only-import concept so I'm not sure the path forward here.
from data.
Thanks π.
Will this be back ported to 5.3 lts?
from data.
Related Issues (20)
- π€οΈ tracking: The Road to Polaris β¨ HOT 4
- Request can't handle `null` as response HOT 3
- Overridden `Model` methods have incorrect `this` type HOT 1
- Custom model instancesβ type is not assignable to `Model` HOT 1
- EmberData's native types don't compile with glint HOT 9
- @ember-data/debug/data-adapter.js: Cannot read properties of undefined (reading 'env') HOT 2
- The kind `collection` is missing in schema-record HOT 2
- "Cannot supply a different store via context than was used to create the request" on autorefresh HOT 2
- Error `Cannot read properties of undefined (reading 'env')` after updating to 5.3.4 (extending `@ember-data/store`) HOT 12
- [5.3.4] EmberData deprecation for `ember-inflector` is incorrect HOT 1
- [5.3.7] Issue with use in nested addon HOT 4
- [5.3.7] when using ember-cli-mirage `ember-inflector` must be a installed, otherwise production build is broken HOT 2
- [5.4.0-alpha.91] Incorrect/Missing typings HOT 4
- Error: Could not find module `@ember-data/adapter/rest` HOT 1
- [5.3.4+] `polyfillUUID` isn't anymore working when there was added over `@embroider/macros` option HOT 1
- Descendants of 'Model' cannot be upcast HOT 1
- 'options' is undefined for 'attr<BooleanTransform>'
- Cannot get the Identifier of the record HOT 10
- spec: cache v3 exploration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data.