Comments (2)
I am still using 0.9.8.1, so i have still not experienced any problems. In order to advance development and support multiple ember versions, i have prepared the test suite to be run with multiple ember versions.
Regarding your proposals, i think we should follow/continue ember approach.
-
Second option, makes sense to me, so far the view can also access the event on other browser events ( click ....) and allow to use preventDefault/stopPropagation on the view to manage App UI logic. I think this feature just extend the api and does not break anything.
-
Event Bubbling is documented and the code can be easily read at the EventDispatcher.
The EventDispatcher executes the event stopPropagation method when it is handled with an eventManagers and does not bubble up it.
That's why bubbling up is done with the gestureManager.
So we could implement the same steps, if the view touchEvent method returns false or the evt has been stopped, the gestureManager must not bubble up.
I don't know if i could be missing something or being wrong with this approach, suggestions are wellcome, @jschilli let me know, if you want to Pull Request against master including some unit Tests.
from ember-touch.
Your second option has been included in the following commit.
I am closing this issue.
from ember-touch.
Related Issues (17)
- Rotation Gesture Recognizer should be built-in
- Delegates documentation incorrect HOT 1
- touchHoldEnd does not allow webkit scroll HOT 4
- Enable an easy way to map tapEnd event to click HOT 13
- Review Doc
- TypeError: Application.registerInjection is not a function with Emberjs RC1 HOT 2
- mobiscroll is not working with ember-touch HOT 3
- Error with Ember master HOT 10
- Should allow arbitrary nesting depth of event managers
- Combined horizontal swipe and native vertical scrolling doesn't work on Android Chrome (V29) HOT 15
- show a replaceable solution if this lib is deprecated HOT 3
- Archive project?
- When appropriate, gestures should work with the mouse HOT 30
- Tap Gesture Recognizer: Allow easy retrieval of underlying touch event or minimally X/Y coordinates.
- SC.Gesture API should support manual trigger HOT 3
- Touch events are not passed through child elements HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-touch.