Git Product home page Git Product logo

Comments (2)

ppcano avatar ppcano commented on August 10, 2024

I am still using 0.9.8.1, so i have still not experienced any problems. In order to advance development and support multiple ember versions, i have prepared the test suite to be run with multiple ember versions.

Regarding your proposals, i think we should follow/continue ember approach.

  1. Second option, makes sense to me, so far the view can also access the event on other browser events ( click ....) and allow to use preventDefault/stopPropagation on the view to manage App UI logic. I think this feature just extend the api and does not break anything.

  2. Event Bubbling is documented and the code can be easily read at the EventDispatcher.

The EventDispatcher executes the event stopPropagation method when it is handled with an eventManagers and does not bubble up it.

That's why bubbling up is done with the gestureManager.

So we could implement the same steps, if the view touchEvent method returns false or the evt has been stopped, the gestureManager must not bubble up.

I don't know if i could be missing something or being wrong with this approach, suggestions are wellcome, @jschilli let me know, if you want to Pull Request against master including some unit Tests.

from ember-touch.

ppcano avatar ppcano commented on August 10, 2024

Your second option has been included in the following commit.

I am closing this issue.

from ember-touch.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.