Git Product home page Git Product logo

Comments (8)

dmathieu avatar dmathieu commented on August 10, 2024

Could you give us an example of handlebars code which does not behaves as expected ?

from ember-bootstrap.

danpl avatar danpl commented on August 10, 2024

Something like this:

{{view Bootstrap.Forms.TextField valueBinding="baz" label="Name of an animal"}}

-- results in a label of "Name Of An Animal", which aside from looking rather ugly, violates all sorts of grammar rules.

from ember-bootstrap.

dmathieu avatar dmathieu commented on August 10, 2024

Yes, this is a bug.
The label should be humanized only if none has been provided and we take it automatically from the value's name.

If you want to work on a pull request, feel free to do so (=> remove the humanize if the label is provided in the tag, but not if it's determined automatically).
Otherwise, I'll look into this in a few days.

from ember-bootstrap.

danpl avatar danpl commented on August 10, 2024

At the moment, I've just commented out the call to human(), but I've forked the repo, and if I have some time tomorrow, I'll have a go at it.

from ember-bootstrap.

danpl avatar danpl commented on August 10, 2024

Had a few spare moments, did a pull request (separate issue, haven't figured out how to link pull requests to an existing issue yet!).

from ember-bootstrap.

danpl avatar danpl commented on August 10, 2024

OK, used the labelCache prop this time, and updated the tests so that they test for correct behaviour.

from ember-bootstrap.

dmathieu avatar dmathieu commented on August 10, 2024

Awesome ! If you open a pull request with this commit, I merge it this morning :)

from ember-bootstrap.

dmathieu avatar dmathieu commented on August 10, 2024

Fixed with PR #60. Thanks @danpl

from ember-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.