Implement /builds as a section of the website instead of a separate app about ember-website HOT 8 CLOSED

Thanks @locks & @mansona.

I think I should have time to do some work on this over the weekend.

_{Sent with GitHawk}

from ember-website.

@mansona I am going to try and pick this issue up when I have some time. I want to confirm the acceptance criteria for this issue.

My understanding is that this issue will be considered resolved when the ember-learn/builds app has been migrated in to this application and its pages live under the /builds route.

Is that correct?

A few other questions to make sure I understand what needs to be done:

• Should /builds show what is currently shown under 'Home'?
• Should the other routes be /builds/canary, /builds/beta, /builds/release?
• Is it correct that no route is needed for LTS?

from ember-website.

Thanks for picking it up @HallDJack!
In short:

• Yes
• Yes
• No

The first phase is to port it over to be functionally the same. For the next phases we might want to propose changes through an RFC.
Oh, one little thing, instead of /builds, it should be /releases. We have already included a redirect since we decided to make that change.

from ember-website.

@HallDJack you are 100% correct, this will be considered done when everything that currently exists in the builds app lives in this app 👍

You are also correct that we do not need a route for LTS 👍 This is a follow-up issue that covers adding functionality to the builds routes but we will be starting to work on that in Phase 2, we don't want it to hold up getting this live 💪

from ember-website.

Hey @HallDJack 👋

I just wanted to check in with you to see if I can help you out in any way? I would say that I wouldn't spend too much time on this port because we're not yet in the phase of making things "look nice" or making the code perfect.

I recently just ported the statusboard over #154 and it a) doesn't look exactly the same and b) the code could be improved but we can worry about that later 🙈

Let me know if there is anything I can help with and I will see what I can do! And I'm always available on Discord to chat if you're interested 😄

from ember-website.

Thanks for the offer @mansona.

I have a branch with all the functionality ported over I just need to pull in the styles. I haven’t had time to work on it this week, but should have time this weekend.

If that doesn’t fit the timeframe that is needed I could PR what I have and let someone else take over. Let me know if I should do that.

_{Sent with GitHawk}

from ember-website.

@HallDJack I would always PR what you have already so people can take a look, but if you get to it this weekend that should be ok on the timeframe 🎉 also I wouldn't worry too much if you don't (in case you get busy) because any contribution is very welcome no matter how big or small!

I will say that I wouldn't worry too much about the styles for 2 reasons: firstly if you look at #154 the styles that were ported over from the statusboard app could do with some serious love 🙈 and secondly, we have a final stage of the process that will be making more sweeping changes #157

When you're looking at this over the weekend I would recommend making it as quick a copy-paste job as you can make it 👍

from ember-website.

@mansona I got the styles mostly working. PR for the port here: #159

from ember-website.