Git Product home page Git Product logo

Comments (3)

ef4 avatar ef4 commented on May 14, 2024 4

I think the distinction should really be made by the consuming application, when it decides whether it wants to expose the engine's route's within its own router map.

Even when it will be used as routeless, it's internal implementation may benefit significantly from using routes. They just won't alter the consuming application's URL.

The simplest example is a routeless engine that wants to having a loading template. There's no reason it can't have an ApplicationRoute with a model hook that returns a promise, which will render application.loading and then application.index.

from ember-engines.

mike183 avatar mike183 commented on May 14, 2024

I believe if you need routes you should be using a routable engine and not a route-less engine.

from ember-engines.

villander avatar villander commented on May 14, 2024

I think the distinction should really be made by the consuming application, when it decides whether it wants to expose the engine's route's within its own router map.

It's doesn't make sense when you have 2 type of engines described on RFC

The real purpose of a engine is represent a app that will be compose into a host. And we can't avoid the ability of the engine be a routable ou route-less by host app, this break the isolation and responsiblity of small app decide and increases the coupling.

The simplest example is a routeless engine that wants to having a loading template. There's no reason it can't have an ApplicationRoute with a model hook that returns a promise, which will render application.loading and then application.index.

Use routable engine for this, if you want a Loading component, use route-less with friendly interface to ember components, or an UI-addon to represent this.

Maybe we can deprecate route-less engine with arriving of Embroider that will be turn easy lazy loading components like Chat or Sidebar instead create a Engine for this.

from ember-engines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.