Comments (3)
I think the distinction should really be made by the consuming application, when it decides whether it wants to expose the engine's route's within its own router map.
Even when it will be used as routeless, it's internal implementation may benefit significantly from using routes. They just won't alter the consuming application's URL.
The simplest example is a routeless engine that wants to having a loading template. There's no reason it can't have an ApplicationRoute with a model hook that returns a promise, which will render application.loading and then application.index.
from ember-engines.
I believe if you need routes you should be using a routable engine and not a route-less engine.
from ember-engines.
I think the distinction should really be made by the consuming application, when it decides whether it wants to expose the engine's route's within its own router map.
It's doesn't make sense when you have 2 type of engines described on RFC
The real purpose of a engine is represent a app
that will be compose into a host. And we can't avoid the ability of the engine be a routable ou route-less by host app, this break the isolation and responsiblity of small app decide and increases the coupling.
The simplest example is a routeless engine that wants to having a loading template. There's no reason it can't have an ApplicationRoute with a model hook that returns a promise, which will render application.loading and then application.index.
Use routable engine for this, if you want a Loading component, use route-less with friendly interface to ember components, or an UI-addon to represent this.
Maybe we can deprecate route-less engine with arriving of Embroider that will be turn easy lazy loading components like Chat or Sidebar instead create a Engine for this.
from ember-engines.
Related Issues (20)
- Loading substate isn't entered when lazily-loaded engine is mounted to root of host app HOT 1
- app.import() content can end up in app's vendor instead of engine's HOT 1
- Prepare for addition of engine-specific router service HOT 5
- Pod style with tailwind inside in-repo engine doesn't processed correctly HOT 3
- [RFC] Deprecate `{ 'engine-service': 'host-service' }` syntax for service dependencies HOT 1
- Lazy loading changes output path of assets HOT 1
- [RFC] Provide `externalRouter` to Engines HOT 5
- `@embroider/macros` macro conditions can sometimes be evaluated incorrectly HOT 1
- Unknown object passed to sourceOfConfig() error HOT 6
- How to install an addon in an engine? HOT 2
- getOwner doesn't return the context for the route HOT 3
- cannot find module "@ember/routing/link-component" in ember ~4.1 HOT 2
- Class extends value [object Object] is not a constructor or null HOT 3
- Could not find module `@ember/legacy-built-in-components` HOT 2
- error reading "inaccessibleByURL" is undefined sometimes
- build error after upgrading to 0.9.0 HOT 3
- Service dependencies do not pass through properly in embedded engine (Ember 3.28) HOT 3
- Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'on') HOT 1
- dependencies do not pass through properly in embedded engine under single spa
- 0.8.22 breaks compatability with Ember > 3.24 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-engines.