Git Product home page Git Product logo

Comments (5)

mattmarcum avatar mattmarcum commented on August 25, 2024

debugged this with @kategengler and traced it to some weirdness in ember-cli-page-object. Its putting weird code in the app's name space.

from ember-cli-code-coverage.

kategengler avatar kategengler commented on August 25, 2024

That's part of it, but also the cause is the code added yesterday to require all files in the project (so that coverage % takes into account files that aren't tested at all).

I think changing this throw to a warning would be a better middle ground: https://github.com/kategengler/ember-cli-code-coverage/blob/master/lib/templates/test-body-footer.html#L10

from ember-cli-code-coverage.

kellyselden avatar kellyselden commented on August 25, 2024

I think I'm getting this issue with some unused mirage code as well FYI. The solution may be to remove the code, but I dunno.

from ember-cli-code-coverage.

rwjblue avatar rwjblue commented on August 25, 2024

Ya, I think we should probably just not throw. However, it almost certainly points out unused code (since if simply requiring throws it is very unlikely to be used).

from ember-cli-code-coverage.

rwjblue avatar rwjblue commented on August 25, 2024

Should be fixed by #64

from ember-cli-code-coverage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.