Git Product home page Git Product logo

Comments (10)

luketheobscure avatar luketheobscure commented on July 23, 2024

I've set up a demo app illustrating this bug: https://github.com/luketheobscure/ember-code-coverage-bug

I don't have the spare time to try to tackle this myself, but I would be happy to test things out.

from ember-cli-code-coverage.

kategengler avatar kategengler commented on July 23, 2024

I wonder if this isn't about coffeescript but is actually another manifestation of this bug #20

That issue was closed in version 0.3.6, could you see if using a newer version fixes this issue for you?

from ember-cli-code-coverage.

luketheobscure avatar luketheobscure commented on July 23, 2024

I updated that demo app to 0.3.9, and it didn't fix the problem.

from ember-cli-code-coverage.

luketheobscure avatar luketheobscure commented on July 23, 2024

Updated bug demo to use 0.3.12, still seeing the same issue. I would be happy to throw a little bit of time at this if you have any feedback on where to start.

Edit: Changing preprocessTree to postprocessTree at least insured that ember-cli-coffeescript was called first, but the files are never passed to CoverageInstrumenter.prototype.processString. Unfortunately I'm completely lost at debugging Broccoli, so that's as far as I got.

from ember-cli-code-coverage.

turboladen avatar turboladen commented on July 23, 2024

+1

from ember-cli-code-coverage.

RobbieTheWagner avatar RobbieTheWagner commented on July 23, 2024

@luketheobscure without knowing the exact issue, I think the before or after of ember-cli-coffeescript needs to be tweaked to allow the addons to run in the proper order https://github.com/kimroen/ember-cli-coffeescript/blob/master/package.json#L74-L81

from ember-cli-code-coverage.

RobbieTheWagner avatar RobbieTheWagner commented on July 23, 2024

Is there anyone using CoffeeScript that would like to test this out with the latest 1.0.0-beta.2?

from ember-cli-code-coverage.

RobbieTheWagner avatar RobbieTheWagner commented on July 23, 2024

@luketheobscure @turboladen can either of your please test this out with the latest beta, 1.0.0-beta.3?

from ember-cli-code-coverage.

luketheobscure avatar luketheobscure commented on July 23, 2024

I'm afraid we migrated all of our projects off of CoffeeScript. https://github.com/decaffeinate/decaffeinate is incredible.

from ember-cli-code-coverage.

RobbieTheWagner avatar RobbieTheWagner commented on July 23, 2024

CoffeeScript works now, I've tested it on a project using it.

from ember-cli-code-coverage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.