I did not get any coverage information for files within the addon subdirectory. This p

Submitted <a class="issue-link js-issue-link" data-error-text="Failed to load title" d

Addon support: no coverage for addon files on Windows,about ember-cli-code-coverage/ember-cli-code-coverage

Comments (4)

rwjblue commented on August 25, 2024

Lets break apart that line a bit, and update your local copy with the snippet below, then tell me what the console output values are..

  doesFileExistIsCurrentProjectAddonModule: function(_relativePath) {
    console.log('_relativePath', _relativePath);
    var relativePathWithoutProjectNamePrefix = relativePath.replace(path.join('modules', this.project.pkg.name), '');
    console.log('relativePathWithoutProjectNamePrefix', relativePathWithoutProjectNamePrefix);

    var relativePath = path.join('addon', relativePathWithoutProjectNamePrefix);
    console.log('relativePath', relativePath);

    if (this._existsSync(relativePath)) {
      return true;
    }

    return this._doesTemplateFileExist(relativePath);
  },

I suspect, that we actually should be doing the following to cleanup/sanitize using / before checking _existsSync:

    var relativePathWithoutProjectNamePrefix = relativePath.replace('modules' + '/' +  this.project.pkg.name, '');

    var relativePath = 'addon/' + relativePathWithoutProjectNamePrefix;
    console.log('relativePath', relativePath);

from ember-cli-code-coverage.

nfc036 commented on August 25, 2024

Hi Robert, thanks for looking into this. Here the output for one file:

_relativePath modules/lib-ember-addon/transforms/tstamp.js
relativePathWithoutProjectNamePrefix modules/lib-ember-addon/transforms/tstamp.js
relativePath addon\modules\lib-ember-addon\transforms\tstamp.js

from ember-cli-code-coverage.

nfc036 commented on August 25, 2024

Indeed, your second code snippet fixes the problem.

from ember-cli-code-coverage.

rwjblue commented on August 25, 2024

Submitted #49 to fix.

from ember-cli-code-coverage.

Recommend Projects