Addon tests never exit about ember-cli-code-coverage HOT 8 CLOSED

Sounds like #32, can you confirm?

from ember-cli-code-coverage.

Possibly? I don't get any failing tests though, which that issue seems to have. The entire suite runs, the process just never exits.

from ember-cli-code-coverage.

I can't even get things working on a fresh addon

$ ember addon demo-addon
$ cd demo-addon
$ ember install ember-cli-code-coverage
$ ember test
ok 1 PhantomJS 2.1 - JSHint | app.js: should pass jshint
ok 2 PhantomJS 2.1 - JSHint | helpers/destroy-app.js: should pass jshint
ok 3 PhantomJS 2.1 - JSHint | helpers/module-for-acceptance.js: should pass jshint
ok 4 PhantomJS 2.1 - JSHint | helpers/resolver.js: should pass jshint
ok 5 PhantomJS 2.1 - JSHint | helpers/start-app.js: should pass jshint
ok 6 PhantomJS 2.1 - JSHint | resolver.js: should pass jshint
ok 7 PhantomJS 2.1 - JSHint | router.js: should pass jshint
ok 8 PhantomJS 2.1 - JSHint | test-helper.js: should pass jshint

1..8
# tests 8
# pass  8
# skip  0
# fail  0

# ok

$ COVERAGE=true ember test
ok 1 PhantomJS 2.1 - JSHint | app.js: should pass jshint
ok 2 PhantomJS 2.1 - JSHint | helpers/destroy-app.js: should pass jshint
ok 3 PhantomJS 2.1 - JSHint | helpers/module-for-acceptance.js: should pass jshint
ok 4 PhantomJS 2.1 - JSHint | helpers/resolver.js: should pass jshint
ok 5 PhantomJS 2.1 - JSHint | helpers/start-app.js: should pass jshint
ok 6 PhantomJS 2.1 - JSHint | resolver.js: should pass jshint
ok 7 PhantomJS 2.1 - JSHint | router.js: should pass jshint
ok 8 PhantomJS 2.1 - JSHint | test-helper.js: should pass jshint

and from there, it hangs

from ember-cli-code-coverage.

Tried updating to [email protected] and re-generating the addon, but no luck there...

I'm wondering if something weird is happening by calling Testem.afterTests. It seems weird that the pause happens before the summary of 1..8 etc etc, like Testem isn't getting the message that it needs to finish up.

Nope. The Testem source code seems to be set up to handle multiple afterTests callbacks just fine...

from ember-cli-code-coverage.

Aaaaand it seems to be a Phantom issue. @kategengler's comment here inspired me to try that out and, sure enough, if I set Testem to run Chrome in CI then everything works as expected.

To get things working for ember-cli/ember-ajax#163 I'm just going to set up Travis to run Chrome instead based on the directions here.

from ember-cli-code-coverage.

There's definitely something funny w/r/t Phantom + Testem + ember test in the last month or so, but I haven't been able to get it into a reproducible scenario. We've been running the top 100 addons ember-try nightly and a few fail because of phantom hanging.

from ember-cli-code-coverage.

Weird. If you do the steps above locally (new addon w/ ember-cli-code-coverage) does it work?

BTW I've got Phantom 2.1.1 installed locally, AFAIK that's what it's running against.

from ember-cli-code-coverage.

Solution: don't use Phantom

from ember-cli-code-coverage.