Support Addon Coverage about ember-cli-code-coverage HOT 12 CLOSED

This is my top priority for this addon, I have a WIP but was waiting for that PR that landed earlier today. That said, I will likely not get to it until July 4 weekend at the earliest.

from ember-cli-code-coverage.

@kategengler do you have a branch we could look at? If I have some free time, I may be able to help out.

from ember-cli-code-coverage.

Just let me know if you want me to take a stab at any of this. So pumped for this addon 😄

from ember-cli-code-coverage.

@rwwagner90 - I did some spike work the other day, but ran out of time to finish the other night (honestly I fell asleep 💤 ). Maybe you could decipher and try to bring it home? https://github.com/kategengler/ember-cli-code-coverage/compare/addon-spike

from ember-cli-code-coverage.

I tested it on one of my addon and it seemed working perfectly 👍
I made some simple changes on my fork regarding tests.

Merging to home should be simple but I am not sure to see all cases and impacts. It seems pretty good to me but I am not mastering addons & hooks and I am sure I miss something ...

@rwjblue I am curious, what is the state of this for you ?

from ember-cli-code-coverage.

@kategengler does the addon spike play nicely with ember-try?

from ember-cli-code-coverage.

@elwayman02 @kategengler I tested it running a ember try:each and I did not experiment any specific issue

from ember-cli-code-coverage.

I found some incompatibilities between addon-spike implementation and usage of eslint in the covered addon.

When running tests with coverage enabled, ember-cli-eslint fails as described in ember-cli/ember-cli-eslint#56.

I suspect the call to preprocessTree in included here. This seams to lead to multiple mergeTrees because of the call to BroccoliMergeTree here

You can find an example of this on this dedicated branch of my addon

Sadly, I have no idea how to fix that or even where to start. I suppose that we have to find another way to include addon files in preprocessTree or something similar. But I am afraid that that my knowledge of broccoli and ember-cli is still too light for now 😕

from ember-cli-code-coverage.

👍 Love this addon. Can someone give me a lay of the land for what needs to be done to make this work with addons? (@rwjblue?)

If I can get a high level overview of what needs needs changing or how an addon's structure is different from an app's, I'm happy to take a stab at addon compatibility.

from ember-cli-code-coverage.

I believe that @bmeurant has been working in cleaning up the spike I linked above.

from ember-cli-code-coverage.

@rwjblue yes I did some (very light) cleanup on your initial work (here). The spike basically works (congrats!). But, as said before, I was stuck because of some incompatibilities with ember-cli-eslint (included call to preprocessTree is leading to multiple merge trees and this is not supported by ember-cli-eslint.

I have still no good knowledge of broccoli & ember-cli internals and I did not have enough time to go deeper to find an alternative. I take any advice. Or @arjansingh, if you want to investigate further, feel free!

BTW, I see now that I generated a lot of noise here with some rebase/squash on local branches, sorry for that 😕

from ember-cli-code-coverage.

I just submitted #31 (thanks to @EWhite613's work on updating my spike).

Can y'all test that PR out and confirm that all is working well?

from ember-cli-code-coverage.