Comments (6)
It doesn't run exhaustive tests, or at least, not the same ones as the action itself. I'll fix.
from cargo-deny-action.
What's strange is that this wasn't caught by CI here, even though it does build the docker image and runs presumably exhaustive tests.
I think a major outcome of this issue's resolution would be to update CI to catch this kind of issue in future, just because failure to do so can be so devastating.
from cargo-deny-action.
Came here to report this, was glad to see it already done! :)
We're also getting this here: https://github.com/ruffle-rs/ruffle/actions/runs/7884522024/job/21513697259
from cargo-deny-action.
@Byron can you quickly check if adding manifest-path: ./Cargo.toml
resolves this? The default I added is theoretically the exact same as if the option isn't set but apparently that is wrong.
from cargo-deny-action.
@Jake-Shadle ./Cargo.toml
helped in our case but Cargo.toml
didn't. Which is even more puzzling...
from cargo-deny-action.
Thanks for trying that out, I have a test now that excercises it, I forgot there are working directory shenanigans inside cargo-deny so it makes sense the ./ would fix it.
from cargo-deny-action.
Related Issues (20)
- Show explicit result if check results in no warnings/errors HOT 8
- Automated publishing based of the releases in cargo-deny core repo HOT 2
- Failing to load advisory database HOT 2
- How do I use this with the package / workspace root being a subdirectory? HOT 3
- Enable use of shared `deny.toml` HOT 1
- Support Windows HOT 3
- Please add git to the cargo-deny container HOT 1
- Support changing the Rust version HOT 1
- Latest release says it's 1.2.20 when it should say 1.2.10 HOT 3
- Add CD for docker images to be uptodate with cargo and rust HOT 1
- Fails to parse Cargo.toml with `strip` is used HOT 1
- Cannot check private repositories HOT 5
- Create an issue when check fails
- The marketplace version is significantly lagging behind HOT 1
- Update cargo deny to 0.14.2 HOT 1
- Can't use ssh to fetch private repos
- This action doesn't seem to respect the current working directory. HOT 5
- existing `cargo-deny-action` jobs with `--manifest-path` now fail HOT 3
- Colorize output
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-deny-action.