Git Product home page Git Product logo

Comments (6)

Jake-Shadle avatar Jake-Shadle commented on May 24, 2024 3

It doesn't run exhaustive tests, or at least, not the same ones as the action itself. I'll fix.

from cargo-deny-action.

Byron avatar Byron commented on May 24, 2024 1

What's strange is that this wasn't caught by CI here, even though it does build the docker image and runs presumably exhaustive tests.

I think a major outcome of this issue's resolution would be to update CI to catch this kind of issue in future, just because failure to do so can be so devastating.

from cargo-deny-action.

torokati44 avatar torokati44 commented on May 24, 2024

Came here to report this, was glad to see it already done! :)

We're also getting this here: https://github.com/ruffle-rs/ruffle/actions/runs/7884522024/job/21513697259

from cargo-deny-action.

Jake-Shadle avatar Jake-Shadle commented on May 24, 2024

@Byron can you quickly check if adding manifest-path: ./Cargo.toml resolves this? The default I added is theoretically the exact same as if the option isn't set but apparently that is wrong.

from cargo-deny-action.

ijc avatar ijc commented on May 24, 2024

@Jake-Shadle ./Cargo.toml helped in our case but Cargo.toml didn't. Which is even more puzzling...

from cargo-deny-action.

Jake-Shadle avatar Jake-Shadle commented on May 24, 2024

Thanks for trying that out, I have a test now that excercises it, I forgot there are working directory shenanigans inside cargo-deny so it makes sense the ./ would fix it.

from cargo-deny-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.