newest collectiveidea's delayed_job about email-spec HOT 10 CLOSED

Minofare has submitted a pull request for this: http://github.com/minofare/email-spec/commits/e36cce7c2afd826c8888dbec82ffc3ee6a47a6de

from email-spec.

I'm going to merge this in but I want to tag the previous releases to the correct delayed_job version. What version of DJ introduced the breaking changes?

from email-spec.

I think the breaking version is 1.8.5. Please correct me if I'm wrong.

from email-spec.

I made the change when collectiveidea/delayed_job was 1.8.4, I did some research and the work_off method was implemented here:

collectiveidea/delayed_job@31cbb07

from email-spec.

After upgrading my delayed job I still get errors with your patch:

Feature: Delayed Job support
  In order for developers using delayed_job to test emails
  I want to be able to provide a compatibility layer, which
  should run all delayed jobs before checking email boxes
  In order to populate deliveries done via send_later

  Scenario: Newsletter                                       
    Given no emails have been sent                          
      undefined method `work_off' for class `Delayed::Worker' (NameError)
      /Users/bmabey/Programming/ruby/email-spec/lib/email_spec/background_processes.rb:19:in `public'
      /Users/bmabey/Programming/ruby/email-spec/lib/email_spec/background_processes.rb:19:in `send'
      /Users/bmabey/Programming/ruby/email-spec/lib/email_spec/background_processes.rb:19:in `reset_mailer'
      ./features/step_definitions/email_steps.rb:44:in `/^(?:a clear email queue|no emails have been sent)$/'
      features/delayed_job.feature:8:in `Given no emails have been sent'

I've merged in the changes but I don't want to make a release until this is passing. It is probably something I am doing wrong on my end. Would someone mind grabbing the code from github and running rake? To run just the delayed job feature you can say cd examples/rails_root/ && cucumber features/delayed_job.feature. (You will need to run rake from the root before you just run the delayed_job.feature.)

from email-spec.

I'm working through this and a few other issues now. Stay tuned.

from email-spec.

Fix available at http://github.com/KieranP/email-spec/commit/51c8c8e916c320064d4211740f426827ab31e6ed

from email-spec.

For the ticket record, the errors Ben was getting were because the delayed job with the changes isn't release yet. We really should support both versions. My patch does that.

from email-spec.

Thanks for the fix Kieran!

from email-spec.

Merged in Kieran's fixes and released 0.6.0.

from email-spec.