Git Product home page Git Product logo

Comments (16)

declantsien avatar declantsien commented on June 6, 2024 1

With --enable-winit-tao the WIP branch works for me.

Be aware, changed to --with-winit=tao.

--enable-wr-glutin changed to --with-wr-gl=glutin

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

Do you mean the second frame or all frames?
Second frame being blank is a known issue, which I fixed in my branch.
20230224_21h15m29s_grim

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

all frames. A breakpoint on flush shows it does get there, but stepping through never causes anything to render.

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

Probably Mutext dead lock from event_loop.rs. I changed some lock() to try_lock()... Are there any Failed to grab a lock from logs?

No, but hang on, that's a good shout, I'll do some digging on the event loop.

EMACSNG_LOG=wrterm=trace ./emacs

Call me stupid but I actually couldn't figure out how to filter by crate. This is enormously useful. Methinks it should be in the docs (or I just missed it).

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

I've PRd some docs. What caught me out was not spotting that tracing's EnvFilter works like env_logging. I was just using grep....

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

Nope, not a mutex problem. None of my quick guesses were right either. I'll dig into this later and figure it out if it's not yet fixed.

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

I replaced all try_locks with lock. Diffing with the working code should show what it is.

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

Would you like to give it a try for the code here #490.
I managed to git cherry-picked all the changes from my tao branch in one patch. @2e0byo

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

That now loads. the scaling code is broken, but it always was with winit. (Causes some weird bug with the cursor as clearly two different values for scale are being used internally.)

I'm a bit out of touch atm as I'm madly finishing my thesis :D But I needed to get Emacs functional first... When the tao/winit split lands upstream I'll try to see what's going on.

I run hyprland mostly and it's definitely more of a problem than e.g. weston. E.g. it sends lots of resize events, so the queue needs to be filtered before processing them, or they take forever to process (and occasionally hang). But all that is on the list for when the next two chapters are in ;)

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

Bother, actually read the source now.

With --enable-winit-tao the WIP branch works for me. (pace some rendering problems which existed before hand). In any case this issue is definitely closed by it.

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

pace some rendering problems which existed before hand

Do you mean the flicking when frame changing focused stated? It can be improved with using tao underline gtk GLContext I think. I may add that later.

For other rendering problems which exist in the issues we can tackle step by step if anyone is interested.

from emacs-ng.

declantsien avatar declantsien commented on June 6, 2024

I'm a bit out of touch atm as I'm madly finishing my thesis :D But I needed to get Emacs functional first... When the tao/winit split lands upstream I'll try to see what's going on.

Good luck with you thesis. I am sticking to PGTK Emacs for now until WR Emacs are ready for daily use.

tao/winit split should happen in the #490. We are waiting for @harryfei 's review. I squashed multi commits into one. There's a lot of changes. Might take some time.
But I am pretty confident about the change though.

from emacs-ng.

2e0byo avatar 2e0byo commented on June 6, 2024

Do you mean the flicking when frame changing focused stated? It can be improved with using tao underline gtk GLContext I think. I may add that later.

Yes. I don't know what you mean with tao, but I'd be glad if it did fix it. I spent some time in the debugger trying to figure out what was blanking the window, but couldn't. It seems to happen outside flush().

I am sticking to PGTK Emacs for now

PGTK was unuseable on this ancient machine---it just can't handle the screen resolution. It's not finished but I'm really happy with emacsng for now.

I'll close this as it's fixed in #490 and I'm still running my own fork.

from emacs-ng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.