Git Product home page Git Product logo

Comments (3)

marthacryan avatar marthacryan commented on May 28, 2024
  • We should validate that the file exists, how often? Do we need to watch the file somehow?

I would think when opening the file and on running / exporting? Also saving? I think that'd be enough

  • Should we change the file label to just be the basename? xxx.ipynb feels a bit noisy...

I think there was some discussion about this recently - if I'm remembering correctly, it was the basename before we added the ability to run python nodes but we started using the full filename because there could be a python node and a notebook node with the same base name? Also because we could change the label of the node. However the nodes do have an icon to indicate the file type so I guess it's not really important for the first reason. @ptitzler I think I remember you bringing this up recently, what do you think?

  • If a file is renamed should the node's file path also be updated?

Is there a straightforward way of finding the new filename? I think that'd be a good feature but I'm not sure how it'd be implemented

from pipeline-editor.

lresende avatar lresende commented on May 28, 2024
  • We should validate that the file exists, how often? Do we need to watch the file somehow?

I would think when opening the file and on running / exporting? Also saving? I think that'd be enough

So, this should be part of the pipeline validation logic, so, whenever the validation occours.

from pipeline-editor.

bourdakos1 avatar bourdakos1 commented on May 28, 2024

Yea, I was assuming during validation was the bare minimum. I was more wondering if we should do any file watching for when required files are renamed/moved

from pipeline-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.