Comments (3)
- We should validate that the file exists, how often? Do we need to watch the file somehow?
I would think when opening the file and on running / exporting? Also saving? I think that'd be enough
- Should we change the file label to just be the basename?
xxx.ipynb
feels a bit noisy...
I think there was some discussion about this recently - if I'm remembering correctly, it was the basename before we added the ability to run python nodes but we started using the full filename because there could be a python node and a notebook node with the same base name? Also because we could change the label of the node. However the nodes do have an icon to indicate the file type so I guess it's not really important for the first reason. @ptitzler I think I remember you bringing this up recently, what do you think?
- If a file is renamed should the node's file path also be updated?
Is there a straightforward way of finding the new filename? I think that'd be a good feature but I'm not sure how it'd be implemented
from pipeline-editor.
- We should validate that the file exists, how often? Do we need to watch the file somehow?
I would think when opening the file and on running / exporting? Also saving? I think that'd be enough
So, this should be part of the pipeline validation logic, so, whenever the validation occours.
from pipeline-editor.
Yea, I was assuming during validation was the bare minimum. I was more wondering if we should do any file watching for when required files are renamed/moved
from pipeline-editor.
Related Issues (20)
- accessibility issue with hover states of string array control HOT 2
- Serialization preprocessing
- Label bug
- When a value isn't defined in current_parameters the values aren't persisted
- Consolidate commands
- The pipeline editor expects a single "extension", but the new spec allows for an array of "extensions" HOT 1
- Inconsistent save behavior when closing properties HOT 6
- Add test case to verify #129 HOT 1
- install instructions don't work in fresh environment
- Update validation checks to include new OneOfControl feature HOT 1
- Upgrade webpack dependency to v6
- Display arrow in link between nodes.
- Add error description to properties
- [VS Code] Make it more clear on how to add nodes to canvas
- Palette improvements
- Make file extensions an array
- Add support for number fields in property editor HOT 1
- String input should be trimmed before checking validity
- Add a settings props for customization
- An empty string should be treated as undefined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pipeline-editor.