Comments (10)
lresende
commented on September 18, 2024
author: @ajbozarth
@lresende He's the code I have that I can't get to build outside JupyterLab. The utils.ts file works when used by fileeditor-extension in JupyterLab but not outside in our code, I've tried all the cleanup I can and it just won't work for me :(
from elyra.
lresende
commented on September 18, 2024
author: @ajbozarth
For reference here's my errors I get:
/Users/ajbozart/workspace/jupyter/ai-workspace/packages/python-runner/src/utils.ts
Error:(140, 35) TS2345: Argument of type '(key: "wordWrapColumn" | "fontFamily" | "fontSize" | "lineHeight" | "lineNumbers" | "lineWrap" | "readOnly" | "tabSize" | "insertSpaces" | "matchBrackets" | "autoClosingBrackets" | "rulers" | "codeFolding") => void' is not assignable to parameter of type '(value: string, index: number, array: string[]) => void'.
Types of parameters 'key' and 'value' are incompatible.
Type 'string' is not assignable to type '"wordWrapColumn" | "fontFamily" | "fontSize" | "lineHeight" | "lineNumbers" | "lineWrap" | "readOnly" | "tabSize" | "insertSpaces" | "matchBrackets" | "autoClosingBrackets" | "rulers" | "codeFolding"'.
Error:(573, 33) TS2345: Argument of type 'IUndoer<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'IUndoer<Widget>'.
Types of property 'undo' are incompatible.
Type '(widget: IDocumentWidget<FileEditor, IModel>) => void' is not assignable to type '(widget: Widget) => void'.
Types of parameters 'widget' and 'widget' are incompatible.
Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
Error:(584, 39) TS2345: Argument of type 'IEditorViewer<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'IEditorViewer<Widget>'.
Types of property 'toggleLineNumbers' are incompatible.
Type '(widget: IDocumentWidget<FileEditor, IModel>) => void' is not assignable to type '(widget: Widget) => void'.
Types of parameters 'widget' and 'widget' are incompatible.
Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
Error:(610, 41) TS2345: Argument of type 'IConsoleCreator<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'IConsoleCreator<Widget>'.
Types of property 'createConsole' are incompatible.
Type '(widget: IDocumentWidget<FileEditor, IModel>) => Promise<void>' is not assignable to type '(widget: Widget) => Promise<void>'.
Types of parameters 'widget' and 'widget' are incompatible.
Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
Error:(617, 36) TS2345: Argument of type 'ICodeRunner<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'ICodeRunner<Widget>'.
Types of property 'run' are incompatible.
Type '(widget: IDocumentWidget<FileEditor, IModel>) => Promise<void>' is not assignable to type '(widget: Widget) => Promise<void>'.
Types of parameters 'widget' and 'widget' are incompatible.
Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
copied from my ide console for easier readability that the terminal output (which has diff's mixed in)
from elyra.
lresende
commented on September 18, 2024
author: @ajbozarth
also @karlaspuldaro if you want to try and see if it works for you :/
from elyra.
lresende
commented on September 18, 2024
author: @lresende
@ajbozart I believe your changes are trying to handle much more than needed, e.g. supporting tracker by extending IEditorTracker which might not completely work in our scenario. At this point, how about you open an issue or start some discussion on Gitter stating your requirements and see if we can get some feedback or suggestions?
from elyra.
lresende
commented on September 18, 2024
author: @lresende
btw, I do see the same issues you mentioned above
from elyra.
lresende
commented on September 18, 2024
author: @ajbozarth
Open issue on JupyterLab for this problem: jupyterlab/jupyterlab#6901 (as suggested in the gitter)
from elyra.
lresende
commented on September 18, 2024
author: @ajbozarth
Open PR based on the discussion in the above issue: jupyterlab/jupyterlab#6904
from elyra.
lresende
commented on September 18, 2024
author: @akchinSTC
jupyterlab/jupyterlab#6904
PR has been merged...yay!
Is this PR tracked in any of the current issues we have open?
from elyra.
lresende
commented on September 18, 2024
author: @ajbozarth
Once I finish my current work on common properties I will return to this PR and update to use the recently merged functionality. And I believe there is a tracking issue in zenhub, but not this repo
from elyra.
lresende
commented on September 18, 2024
author: @ajbozarth
Given how much has changed since I last worked on this PR I am going to close and abandon it and start from scratch
from elyra.
Related Issues (20)
- Unable to use KUBERNETES_SERVICE_ACCOUNT_TOKEN authentication method HOT 2
- Common or shared variables for different notebooks in a pipeline HOT 9
- Does elyra stop update new version anymore? HOT 1
- Unable to include folder/dir as deps in elyra pipeline from node properties.
- Introduce pipeline version with numbers(v1,etc) instead of datastamp HOT 1
- ODH Quick Install links are broken HOT 3
- Support AWS airflow configuration
- elyra-pipeline validate CLI command fails for pipelines with parameters and default properties HOT 1
- Kubeflow Pipelines runtime configuration HOT 1
- Fix/Add back support for Python 3.11 HOT 1
- Local development setup not working HOT 6
- Read the Docs: Update integration webhook secret
- support up-to-date python on community images for enterprise gateway
- Link to Contributing doc is broken HOT 4
- Fetch environment variables from a Notebook's environment
- No logging in container for python scripts nodes HOT 4
- DBT Editor support
- nbconvert requires lxml_clean_html HOT 7
- Palette nodes expanded by default in UI
- Customize pipeline property in pipeline editor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elyra.