Git Product home page Git Product logo

Comments (6)

mkozjak avatar mkozjak commented on May 20, 2024

Currently ID cannot be set manually. Why would you need this? ID is set automatically and should not make any differences for you at all..

from rpc-websockets.

meotimdihia avatar meotimdihia commented on May 20, 2024

Sorry, it is work now, but response time is very slow.

ws.on('open', function() {
  // call an RPC method with parameters

    ws.call('getCurrency', {currency: 'ETH'}).then(function(result) {
      console.log(result)
    })

    ws.call('login',{
        "algo": "BASIC",
        "pKey": key,
        "sKey": secret
      }
    ).then(function(result) {
        console.log(result);
        ws.call('getTradingBalance').then(function(result) {
        console.log(result);
      }
  });
})

Its faster if i use ws package. Do you have any suggestion about this? :)

from rpc-websockets.

mkozjak avatar mkozjak commented on May 20, 2024

I highly doubt it it's slower than ws, because I'm using uws instead, which is a lot faster. Can you provide any tests and times?

from rpc-websockets.

meotimdihia avatar meotimdihia commented on May 20, 2024

If you run this code, it take more than 10s to return response

index.js

const rpc = require('rpc-websockets').Client

const baseUrl = 'wss://api.hitbtc.com/api/2/ws';

var ws = new rpc(baseUrl)

ws.on('open', function() {
  // call an RPC method with parameters
  ws.call('getCurrency', {currency: 'ETH'}).then(function(result) {
    console.log(2);
    console.log(result)
  })
})

index2.js under 5s

const WebSocket = require('ws');

const baseUrl = 'wss://api.hitbtc.com/api/2/ws';

var ws = new WebSocket(baseUrl)
ws.on('open', function() {
    console.log('open');
    ws.send(JSON.stringify({
      "method": "getCurrency",
      "params": {
        "currency": "ETH"
      },
      "id": 123
    }));
})

ws.on('message', function incoming(data) {
    console.log(1);
    console.log(data);
});

and its strange, if i combile code in 2 files, then code use rpc-websockets will response immeditely.

from rpc-websockets.

mkozjak avatar mkozjak commented on May 20, 2024

On a Mac Mini 1 is 0.13s user 0.03s system 50% cpu 0.307 total and 2 is 0.11s user 0.03s system 46% cpu 0.289 total.

rpc-websockets does some computation with ws data, hence the overhead. But this is nowhere 5 or 10 seconds.

from rpc-websockets.

meotimdihia avatar meotimdihia commented on May 20, 2024

I found out the problem:
Reason is node version. I removed node 8.9 on my Windows Creators then reinstall node 6.x.

from rpc-websockets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.