Git Product home page Git Product logo

Comments (13)

elParaguayo avatar elParaguayo commented on July 17, 2024 1

No need to apologise. It's good to spot the issue. I've submitted a PR to fix it so no need to open a new issue there (it would still be me dealing with it).

Ideally, it would be great if you could test that the fix works for you.

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024 1

No rush at all.

The fix I've submitted will preserve the behaviour of the negative length widgets.

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024 1

Interesting. I'll see if I can take a look later this week.

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024

Thanks. I'll take a look when I can.

NB any widget that needs to have different behaviour depending on which screen it's displayed (e.g. GroupBox) should notbe mirrored, you should create a new instance for each screen. Mirrors just display the same contents as the original and pass button clicks to that widget rather than triggering their own behaviour.

from qtile-extras.

MagnuSiwy avatar MagnuSiwy commented on July 17, 2024

Good to know, thank you! I will change the config to avoid that. Unfortunately at the moment even if not mirroring the widgets that need to have different functionality it still doesn't work.

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024

I think it's your negative value Spacer widgets that are breaking this.

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024

Those widgets are not drawn in the original bar (as they only draw when the length is > 0) but I suspect they are taken into account when trying to position various other widgets.

However, the mirror widget has no check for the negative width value and so breaks.

I think this is actually an issue in main qtile.

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024

I think this fixes it: qtile/qtile#4714

from qtile-extras.

MagnuSiwy avatar MagnuSiwy commented on July 17, 2024

Oh, I'm sorry then. That's true, I was testing it on qtile before I added those spacers, so it might be the main qtile issue after all. I added the negative values to "remove" the padding when the widgets are grouped and it worked perfectly with just the one bar. Actually it is breaking right after the calendar icon where the first spacer is.

Should I make an issue on main qtile? I don't think it's a bug then, I was just trying to "break the system". Is there any other way or maybe it's an idea for something to add to qtile, to separate padding_x or padding into padding for each of the sides?

from qtile-extras.

MagnuSiwy avatar MagnuSiwy commented on July 17, 2024

I will try the changes tomorrow if that's not a problem. Will this affect the way the negative length works on the widgets? I still don't understand all of the code hah

Thank you for all of the help!

from qtile-extras.

elParaguayo avatar elParaguayo commented on July 17, 2024

Ha. It's already been merged by another one of the devs so you just need to update to latest version of qtile.

from qtile-extras.

MagnuSiwy avatar MagnuSiwy commented on July 17, 2024

Oh boy, you work fast. Amazing!

from qtile-extras.

MagnuSiwy avatar MagnuSiwy commented on July 17, 2024

Ok, it works perfectly now. The only thing I can think of is that the checkupdates widget on the second screen has to refresh before the decorations start working. It's not really a problem, just something I noticed

from qtile-extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.