Git Product home page Git Product logo

Comments (8)

evancz avatar evancz commented on June 9, 2024

Does this happen in 0.16 as well? If so, what do you propose as the fix?

from virtual-dom.

etaque avatar etaque commented on June 9, 2024

Doesn't happen with 0.16, I discovered my mistake in this package while migrating it to 0.17 (it wasn't triggering any runtime error in 0.16)

from virtual-dom.

evancz avatar evancz commented on June 9, 2024

It looks like the new and old libraries are doing exactly the same things. As far as I can tell, both are doing:

var node = document.createElement('select');
node['type'] = 'checkbox';

I guess something is happening in between those two things. I looked at all the fields in node and there are definitely fewer in the new one. I don't really understand how or why.

from virtual-dom.

etaque avatar etaque commented on June 9, 2024

That could be related to strict mode and browser versions, I'm investigating.

Edit: re-checked 0.16 version, confirm it doesn't raise error for same Chrome version. So it's probably due to a strictness context change around this call?

from virtual-dom.

etaque avatar etaque commented on June 9, 2024

See here:
http://www.ecma-international.org/ecma-262/5.1/#sec-11.13.1 (NOTE section)

from virtual-dom.

rtfeldman avatar rtfeldman commented on June 9, 2024

This still throws a runtime exception in 0.18. I updated OP to reflect this.

from virtual-dom.

evancz avatar evancz commented on June 9, 2024

Tracking in #106 which is for any type_ issues.

Please continue discussion here if there is more information to share. The point of the meta issue is to do some organizing and editorializing that makes it easier to make progress on this sort of thing.

from virtual-dom.

szg251 avatar szg251 commented on June 9, 2024

It is an even sillier mistake on my part, but I accidentally left a class attribute from Html.Attributes in an svg element. I am using 0.19.1.
https://ellie-app.com/7xG7sn9nrB2a1

from virtual-dom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.