Annoyance with deps striking back about plug HOT 13 CLOSED

If you are using @HashNuke's buildpack you can set always_rebuild=true in the buildpack config to not use the cached dependencies. Alternatively you can use https://github.com/heroku/heroku-repo and run heroku repo:purge_cached to remove everything cached.

from plug.

Yup but the thing is it didn't work with always_rebuild=true.

Thx for the heroku-repo tip!

Anyway, I think this could be improved in the long run. I intend to leave this issue for a while so I'd investigate it by myself (some ensure_loaded? stuff?). Is it ok?

from plug.

Yup but the thing is it didn't work with always_rebuild=true.

I will look into always_rebuild=true not working.

Anyway, I think this could be improved in the long run. I intend to leave this issue for a while so I'd investigate it by myself (some ensure_loaded? stuff?). Is it ok?

It looks like there may be an underlying issue in mix's dependency compilation. I don't think the issue is on plug.

from plug.

I see. OK then. :)

from plug.

@ericmj I think this issue is the same as elixir-ecto/ecto#264. Because we no longer always call mix deps.loadpaths, when we compile a dependency, its dependencies were not loaded, leading to both failures.

from plug.

Fixed on Elixir master.

from plug.

Wow that was fast :DD kudos

from plug.

@josevalim FYI reporting that this error still exists in 1.0.0-rc1

from plug.

@herenowcoder Have you tried removing _build? @edgurgel had the same issue on 1.0.0-rc1 and that seemed to fix it.

from plug.

Ping, is this still an issue?

from plug.

unfortunately had no time to check. I've had this on heroku where I suppose _build is cleaned.

from plug.

@herenowcoder _build is not cleaned on heroku unless you set always_rebuild=true or explicitly clear the cache.

from plug.

@ericmj thx for the info.

@josevalim I totally don't have time to reproduce the conditions :( - combination of Elixir & deps which led to this.

What I can to is to prepare carefully for some regression next time if it happens, though I hope the deps issues are over.

And btw, Congrats for 1.0.

from plug.