Routing based on the subdomain about plug HOT 6 CLOSED

This is great! As far as I understand, now I can

match "/api-call", via: :post, host: "api."

right? This is a great first step in supporting host-based routing. If I learn enough Elixir to come up with an elegant solution for at least forwarding routes to other plugs based on the domain I'll open a PR.

Again, thank you so much. Elixir is a wonderful language, but it's thanks to the attitude of people like you that I can easily imagine a brilliant future for it. And I'm looking forward to being a part of it 😃

from plug.

I think we could indeed support the host option. But we don't have scope, so you would either have to forward it or repeat it everywhere, but definitely doable!

from plug.

Yes, scope is the perfect context for this feature since it allows to define a group of routes under the same conditions --- in this case, the subdomain. Forwarding to another plug could be a great start in my opinion: something like

forward "*", host: "api.", to: AnotherPlug

allows for a clean syntax and encourages modularity. I don't think this is a permanent solution since one could need to dynamically dispatch based on the subdomain (e.g. [username].github.io), but it's a start!

I still don't have the Elixir skills I think are necessary for adding this feature to Plug, but I'd be happy to help in any other way!

from plug.

Done in a9eba75.

I got curious how this would work with Plug, as I would have to refactor some bits first, but it was easier than expected. :D

from plug.

Forwarding works too. Maybe I should have updated its docs too? There are
tests though. :)

José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Lead Developer

from plug.

Well, great! I'll open a PR with some updated docs as soon as I can then :)

from plug.