Plug.Test support for repeated request headers about plug HOT 5 CLOSED

How do we add multiple response headers? I believe it is merge_response_headers? Whatever API we have there we should mirror here.

from plug.

Plug.Conn.merge_resp_headers/2 has a similar issue to put_resp_header, as it collapses headers down to a single instance value:

conn
|> put_resp_header("test", "123")
|> merge_resp_headers([{"test", "456"}, {"test", "789"}])
|> Map.get(:resp_headers)

# => [{"cache-control", "max-age=0, private, must-revalidate"}, {"test", "789"}]

On the other hand, prepend_resp_headers/2 seems to do the trick, but does them in a different order than I would personally expect:

conn
|> put_resp_header("test", "123")
|> prepend_resp_headers([{"test", "456"}, {"test", "789"}])
|> Map.get(:resp_headers)

# => [
  {"test", "456"},
  {"test", "789"},
  {"cache-control", "max-age=0, private, must-revalidate"},
  {"test", "123"}
]

At the same time, my add_req_header/3 implementation does the same thing (for the order that would be expected, it would need to be headers ++ [{key, value}]—which would have performance issues.

from plug.

So we can have prepend_req_headers and merge_req_headers with the same semantics. I don't think we should introduce a new verb. :) PRs welcome!

from plug.

Working on it.

The implementation of prepend_resp_headers does this: %{conn | resp_headers: headers ++ resp_headers}. Would it be worthwhile adding append_resp_headers and append_req_headers that does the opposite?

from plug.

No plans for new verbs for now, unless it is strongly needed.

from plug.