nested params parser result is different between plug and rails about plug HOT 5 CLOSED

Thanks for the report. Can we look at other parsers? Do we have use cases where those formats would be used so we can evaluate this based on actual usage patterns?

from plug.

The result of the qs parser (part of the Node eco-system) is this:

{"array":[{"foo":["foo1","foo2"],"bar":"bar2"}]}

If I parsed it 'manually' by reading it I'd expect this result. The fact that foo1 and foo2 are both values of [][foo] mean they should be together as elements in the foo array, bar is separate.

from plug.

Should we test as many parsers as we can and try to adapt to the most common behaviour or just leave the parser as is? I feel this issue is an easy one once we understand what should be done 😸.

from plug.

Thanks everyone!

So, I don't agree with node's result because I would expect to achieve that if I had this:

/?array[][foo][]=foo1&array[][foo][]=foo2&array[][bar]=bar2

For example, that's exactly what I get by serialising the value back to param using jQuery:

> decodeURIComponent(jQuery.param({"array":[{"foo":["foo1","foo2"],"bar":"bar2"}]}))
"array[0][foo][]=foo1&array[0][foo][]=foo2&array[0][bar]=bar2"

I don't seem to find any consensus here. jQuery will serialize arrays only if you have string. Check this out:

decodeURIComponent(jQuery.param({"array":[{"foo": "foo"}, "bar2"]}))
"array[0][foo]=foo&array[]=bar2"

Because the first element of the array is an object, it actually indexed it as array[0]. So it seems what we are trying to discuss will never be generated by jQuery and it is hard to come up with any conclusion unless we discuss how and why this is being generated.

from plug.

I am closing this. Once we have real data and real forms we can always reopen and rediscuss!

from plug.