Build Context about publish-docker-github-action HOT 12 CLOSED

I can take this issue.

from publish-docker-github-action.

Maybe I don't get it correct, but why wouldn't you do workdir: ..? https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/README.md#workdir

from publish-docker-github-action.

- abc (folder)
|- Dockerfile
|- xyz (build context for Dockerfile)
|- blah blah..
|- important stuff
|- Dockerfile2
|- xyz2 (build context for Dockerfile2)

Incase of workdir, we wont be able to left xyz2 folder, so in case of build context argument, we can define abc as the workdir and specify Dockerfile along with build context. Hope it makes sense.

from publish-docker-github-action.

Sorry, I don't get it.
The checkout would get abc, as that's the root. So there wouldn't be the need for workdir: .. anyway. You can define the Dockerfile by https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/README.md#dockerfile , which can reference the files in xyz or xyz2.

from publish-docker-github-action.

Please read this-> https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#understand-build-context
You will get a better idea about why it is required.

from publish-docker-github-action.

Ok, let me sum this up.
There are multiple Dockerfiles inside a repository.
We want to build one of them and avoid sending the unneeded resources, which are probably needed by another Dockerfile, to the deamon.
We can't use .dockerignore , because this would also affect the other Dockerfiles builds.
So why can't we have

- abc (folder)
|- xyz (build context for Dockerfile)
|-- Dockerfile
|- xyz2 (build context for Dockerfile2)
|-- Dockerfile2

and use workdir ?

I would like to avoid as much magic as possible...

from publish-docker-github-action.

If I change the change the workdir to xyz, it wont be able to find the location of Dockerfile as it is in the parent dir to xyz.

from publish-docker-github-action.

So what limits you from moving it into xyz?

from publish-docker-github-action.

Well, that's not actually a solution. There are cases where such scenarios occur and because of that docker has provided a build-context feature.

from publish-docker-github-action.

Could you please make an example where this wouldn't be a solution?

from publish-docker-github-action.

I would like this feature too

from publish-docker-github-action.

There you go https://github.com/elgohr/Publish-Docker-Github-Action/releases/tag/2.9
https://github.com/elgohr/Publish-Docker-Github-Action#context

from publish-docker-github-action.