Cache option not working in PR merges about publish-docker-github-action HOT 9 CLOSED

Hi,
as you can see here #24 (comment) PRs aren't build as "latest", in this way they also don't cache latest.
Makes sense?

from publish-docker-github-action.

I see, but it can definitely uses the cache from previous builds, for example the part of the dependencies would not change much between builds but even so it would rebuild it.

Is it possible to make the cache? Being used everywhere?

from publish-docker-github-action.

I don't see where this would make sense, as you want to build the PR and not (accidentally) parts of master.

from publish-docker-github-action.

But for example the first parts where you install the Linux dependencies and the app the packages they don't change often so it's a waste of time. And it takes like 4 mins so is better to use any cache

from publish-docker-github-action.

So how do you make sure that these dependencies are the latest for this PR?

from publish-docker-github-action.

If the Gemfile changes it will also Change the Gemfile.lock so it will invalidate the cache from there on. Regarding the Linux dep we will need to figure it out.

And the same question to you, how will it ensure that on master the cache is invalid.?

Thanks anyway :)

from publish-docker-github-action.

Please read the documentation again (https://github.com/elgohr/Publish-Docker-Github-Action#cache). At the moment that's your job.

from publish-docker-github-action.

I guess we can close this?

from publish-docker-github-action.

Well it didn't solve my question. Because I want to use the cache in the builds of the PR. The user should have the opportunity to use it everywhere and he has the responsibility to decide when to change the cache or not.

For example I can activate depending of the commit message or not

from publish-docker-github-action.