Git Product home page Git Product logo

Comments (9)

elgohr avatar elgohr commented on June 3, 2024 3

I guess having workdir in checkout might take some time.
In this way I introduced it here, so that people can already work.
When it's introduced in checkout, it will be deprecated.
See https://github.com/elgohr/Publish-Docker-Github-Action/releases/tag/1.13 and https://github.com/elgohr/Publish-Docker-Github-Action#workdir

from publish-docker-github-action.

remorses avatar remorses commented on June 3, 2024 2

Edit: not working, the path argument just create a new directory and put the repository there

You can use the path input in the checkout step

    steps:
    - uses: actions/checkout@v1
      with:
        path: your_path

All the steps after that should use that path as the working directory

from publish-docker-github-action.

automada avatar automada commented on June 3, 2024 1

That is great @elgohr! Thanks for the follow-up and fix πŸ‘

from publish-docker-github-action.

alexnuttinck avatar alexnuttinck commented on June 3, 2024 1

Thanks @elgohr!

from publish-docker-github-action.

elgohr avatar elgohr commented on June 3, 2024

Thank you for the request and fast response ☺️
Didn't know about the path in the checkout either. I guess we can close it?

from publish-docker-github-action.

automada avatar automada commented on June 3, 2024

That was quick! Thanks for the response and tip. I tried setting the path, but it seems to only append it to the path context:

/home/runner/work/myrepo/added_in_path

The actual workdir is the same (not sure about the use case for this). I did a pwd inside the action, and it lists the same content even after the path is set.

I also looked at the working-directory variable, but that doesn't seem to work with the uses statement:

https://github.community/t5/GitHub-Actions/Github-actions-working-directory-incorrectly-documented/td-p/29201

Maybe I'm missing something here, but I still cannot see another solution that to pass the path in to the action.

from publish-docker-github-action.

elgohr avatar elgohr commented on June 3, 2024

I'm trying to get an answer from Github whether there is a way to contribute to the checkout plugin, as this seems to be the one doing the actual checkout. At my point more actions could benefit from this, when it's in the checkout.

from publish-docker-github-action.

automada avatar automada commented on June 3, 2024

Sounds like a good plan. I agree that this is a feature that more would benefit from. That is why I almost took it for granted. Hence the feeling I'm missing a feature that already exist :)

from publish-docker-github-action.

alexnuttinck avatar alexnuttinck commented on June 3, 2024

Hello,

I face the same problem. My Dockerfile is generated in another step after the checkout step. So, the path input fix doesn't work for my case.

The additions made by @automada makes sense for me. But I think it would be better if we can use the working-directory variable with the uses statement.

from publish-docker-github-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.