Comments (6)
Also there are still tests failing because of port binding:
Failed to bind socket for 127.0.0.1:44971: Address already in use
unfortunately every fix i tried made it worse
from lightning.
So for the port-binding we usually use the ephemeral_port_reserve
package (or similar) that pre-binds a random port, and we can then take control of it by using the SO_REUSEADDR
(allowing us to grab the port despite it being in a WAIT
state). This means we can use the OS to distribute unique ports. We usually run into port conflicts when not using the reserve
method of the package and just use a random port (without giving the OS a chance to tell us that it is already being used). Another case is when we let too much time elapse between reservation and binding (as the port loses the WAIT
status and may be re-assigned), so reserve briefly before using, and reserve a new port if you can't ensure short downtime on that bind.
from lightning.
I think I fixed a test_penalty_htlc_tx_timeout[True] flake in #7364...
from lightning.
Excellent, looks quite good. Let's merge and I can update the table (strike the entry through) if we can see it settle in 👍
from lightning.
Here are the current outcomes for the branch of #7364:
select count(*), outcome from testruns where github_ref LIKE '%7364%' AND testname LIKE '%penalty_htlc_tx_time%' group by outcome;
22|2 # Success
2|3 # Failure
4|4 # Skipped
So it looks like it is partially fixed (~10% failure rate compared to the above 17%), but not stable.
from lightning.
A quick update on the stats, some got better some got worse:
Test Name | Runs | Failures | Flakyness |
---|---|---|---|
test_rbf_reconnect_tx_construct | 10 | 5 | 33.33% |
test_grpc_connect_notification | 63 | 26 | 29.21% |
test_wss_proxy | 68 | 22 | 24.44% |
test_anchorspend_using_to_remote[True] | 54 | 17 | 23.94% |
test_onchain_their_unilateral_out[True] | 60 | 12 | 16.67% |
test_penalty_htlc_tx_fulfill[True] | 50 | 10 | 16.67% |
test_penalty_htlc_tx_timeout[True] | 50 | 10 | 16.67% |
test_penalty_outhtlc[True] | 59 | 10 | 14.49% |
test_penalty_rbf_normal[True] | 59 | 10 | 14.49% |
test_onchain_middleman_simple[True] | 60 | 10 | 14.29% |
test_onchain_middleman_their_unilateral_in[True] | 60 | 10 | 14.29% |
test_onchain_timeout[True] | 60 | 10 | 14.29% |
test_penalty_inhtlc[True] | 60 | 10 | 14.29% |
Notice that we are not doing as many tests, likely because of the release feature freeze last month.
from lightning.
Related Issues (20)
- Testing wallet generation, restoration with BIP39 give me a Wallet sanity check failed error HOT 1
- Verify
- The assets are not yet shown in my wallet
- Issue
- Issue
- Core Lightning DOES NOT support sending payments HOT 1
- plugin-sql crashes after payed hold invoices expired
- Using fetchinvoice on a Phoenix Bolt12 offer crashes CLN HOT 10
- pytest on Windows requires higher version of python-bitcoinlib HOT 1
- nix build on recent master fails
- renepay fell over HOT 1
- bkpr - get entries by payment id
- CI Complaint about spend_tag in test_onchain_their_unilateral_out[True] HOT 1
- renepay crash on `linearize_channel` HOT 2
- Fix and enable github action for `Publish Python distributions to PyPI and TestPyPI`
- Bad commit sig in splicing (CI fail) HOT 2
- Lock values in documentation examples
- `getroutes`: amounts and delays are wrong HOT 4
- `askrene-reserve`: "guide_must_be: Assertion `actual == c' failed" HOT 2
- `askrene-inform-channel`: maximum_msat minimum_msat mismatch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning.