Comments (4)
I can't reproduce this. Which doesn't surprise me, since we don't really treat those strings at any point.
What are you paying with? Did it mess up somehow?
Here's my simple test:
def test_pay_offer_case_sensitive(node_factory, bitcoind):
l1, l2 = node_factory.line_graph(2, opts={'experimental-offers': None})
offer1 = l2.rpc.offer(amount='any', description='simple test')
offer2 = l2.rpc.offer(amount='any', description='simple Test')
assert l1.rpc.decode(offer1['bolt12'])['offer_description'] == 'simple test'
assert l1.rpc.decode(offer2['bolt12'])['offer_description'] == 'simple Test'
inv1 = l1.rpc.fetchinvoice(offer=offer1['bolt12'], amount_msat=100)
inv2 = l1.rpc.fetchinvoice(offer=offer2['bolt12'], amount_msat=100)
assert l1.rpc.decode(inv1['invoice'])['offer_description'] == 'simple test'
assert l1.rpc.decode(inv2['invoice'])['offer_description'] == 'simple Test'
l1.rpc.pay(inv1['invoice'])
assert only_one(l2.rpc.listoffers(offer1['offer_id'])['offers'])['used'] is True
assert only_one(l2.rpc.listoffers(offer2['offer_id'])['offers'])['used'] is False
from lightning.
Guys I am sorry waste your time on this. I was unable to replicate the issue on my side. I was certain at the time I had found a bug, but I apparently I had just confused myself. It's been known to happen.
from lightning.
yes @rustyrussell in Austin I wrote your same test and I was not able to reproduce, and I ask @farscapian to look the step to reproduce it
from lightning.
np was easy to write a test for it
from lightning.
Related Issues (20)
- Testing wallet generation, restoration with BIP39 give me a Wallet sanity check failed error HOT 1
- Verify
- The assets are not yet shown in my wallet
- Issue
- Issue
- Core Lightning DOES NOT support sending payments HOT 1
- plugin-sql crashes after payed hold invoices expired
- Using fetchinvoice on a Phoenix Bolt12 offer crashes CLN HOT 10
- pytest on Windows requires higher version of python-bitcoinlib HOT 1
- nix build on recent master fails
- renepay fell over HOT 1
- bkpr - get entries by payment id
- CI Complaint about spend_tag in test_onchain_their_unilateral_out[True] HOT 1
- renepay crash on `linearize_channel` HOT 2
- Fix and enable github action for `Publish Python distributions to PyPI and TestPyPI`
- Bad commit sig in splicing (CI fail) HOT 2
- Lock values in documentation examples
- `getroutes`: amounts and delays are wrong HOT 4
- `askrene-reserve`: "guide_must_be: Assertion `actual == c' failed" HOT 2
- `askrene-inform-channel`: maximum_msat minimum_msat mismatch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning.