Comments (2)
After a day of working I just recognized how stupid I was. Of course the parent this.props.content
is the array which contains the rendered childs. I simply can iterate over this array and insert the items as well as the html in between into a new array and then render the new array in the parent.
from create-divi-extension.
QA Checklist
Reporter
- Helpful title used
- Helpful title format:
Scope(s) :: One Sentence To Describe The Issue
- Example:
VB :: Floating Toolbar :: Jumps To Top Of Page
- Helpful title format:
- Detailed description
- Description should usually be 150+ characters.
- Steps to reproduce included
- Support Ticket URL included
- Image and/or gif
Developer
- Steps to reproduce proven solved
- Test included and coverage acceptable and all Tests passing?
- PR description has layman's description of problem and solution and "Areas Affected" listed/explained?
- PR branch includes latest commits from master branch (at the time of checking)?
- Estimated points on issue
- Proper code documentation and conventions?
- Proper RTL appearance
- i18n used if applicable
- Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
- Database saved/updated? Data sanitized and validated?
- Variable output properly escaped and validated?
Peer Review
- PR branch includes latest commits from master branch (at the time of checking)?
- Steps to reproduce proven solved
- Affected areas are tested and ok
- Proper code documentation and conventions
- Proper RTL appearance
- i18n used if applicable
- Test(s) included and coverage acceptable
- Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
- Database saved/updated? Data sanitized and validated?
- Variable output properly escaped and validated?
Quality Assurance
- All tests passed on CircleCI.
- Steps to reproduce passed, the fix works.
- No errors in console or output
- Affected areas are tested and ok
- The fix does not change a customer's website in any surprising or unintended way
- If Divi's design is adjusted, settings are migrated gracefully and invisibly
Design Review
- UI is to spec
- UX is to spec
- Design is to spec
- No surprising visual changes to a customer's website will be experienced after updating
- Any/all visual changes are migrated gracefully
Dev Review
- Test(s) included and coverage acceptable
- Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
- Database saved/updated? Data sanitized and validated?
- Variable output properly escaped and validated?
- i18n used if applicable
- Implementation acceptable, DRY, Scaleable, future safe
- Best practices used, cleverness and grokage, ES6 use, etc.
from create-divi-extension.
Related Issues (20)
- unable to save child item in divi themes properly
- Custom fields styles no loading on Editor HOT 3
- Support for the experimental syntax 'dynamicImport' isn't currently enabled
- node-sass HOT 1
- Problem DIVI causing HTTP 500 on WooCommerce API
- Trying to get the version of the divi builder via PHP.
- How to link the field in the theme builder with the field from my custom post type
- Make upload field return image ID instead of URL
- Custom Taxonomies for Shop module
- Not able to create Divi Extensions HOT 10
- Multi-site issues with updating Divi extensions
- How to add a javascript onclick event to an element in a custom module HOT 1
- add_rewrite_rule breaks Theme/Visual Builder
- Access to @Divi/components or similar repository/package HOT 6
- displaying custom detail page while using divi templates
- DIVI Builder not workding | [React-imported-component] TypeError: n(...) is not a function
- Disable Divi Premade Layout
- et_pb_contact_form_submit not fired when JavaScript is enabled HOT 1
- How to get page specific content in rest api
- et-cache directory overpopulating
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-divi-extension.