Git Product home page Git Product logo

Comments (1)

questor avatar questor commented on June 11, 2024

I have a fix, but not a fully one, because of that also no pull-request. First a test to verify the behaviour:
add this to TestVector:

 	// Issue #524 check
 	{
 		struct S {
 			std::string s;
 		};
 		{
 			S s = {"Hello World!"};
 			eastl::vector<S> v;
 			v.pushBack(s);
 			v.pushBack(v.back());
 
 			VERIFY(v[0].s.compare("Hello World!") == 0);
 			VERIFY(v[1].s.compare("Hello World!") == 0);
 
 			VERIFY(v.size()==2);
 		}
 	}

the fix is (approx line 1946 in vector.h):

			//here #524 is fixed!
			::new((void*)(pNewData+(mpEnd-mpBegin))) value_type(eastl::forward<Args>(args)...);				//first construct the new element in the destination buffer because the source might get moved away by the next line
			pointer pNewEnd = eastl::uninitializedMove_ptr_if_noexcept(mpBegin, mpEnd, pNewData);			//and here copy the rest of the elements into the new buffer
			pNewEnd++;

BUT this will only fix the issue if you have exceptions disabled, when they're enabled it's NOT fixed (and I'm not confident enough to also fix the behaviour here).

from eastl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.