Comments (4)
This has been a subject of much debate internally at EA on whether ea-async should unpack the exception or not.
The argument for making the change is as you rightly point out, it's annoying to have to catch CompletionException
and then unpack it.
The argument for returning the CompletionException
as is, is that it's consistent with the JDK API, such as if you call CompletableFuture.join
.
from ea-async.
Is it possible to make behaviour configurable? For example, as a java agent option
from ea-async.
In my opinion, there is one reason not to auto-unpack the CompletionException
(even if it is annoying).
If you want to catch a checked exception, the compiler will complain, because as far as it knows, await
doesn't throw checked exceptions. An ugly workaround would be to catch Exception
and check its type using instanceof
, which is hardly less verbose than unwrapping the CompletionException
.
from ea-async.
Yeh @Maia-Everett. That has been one of the reasons folks have discussed internally.
In general I'm not a fan of doing the unpacking because it's inconsistent with the expected behavior of CompletableFuture.
from ea-async.
Related Issues (20)
- How to cancel a Promise ? HOT 2
- Error with Arrays
- Says "the method invoking await must return a CompletableFuture" but it does already HOT 4
- Java 11 HOT 2
- Without EA Async (2) HOT 2
- Wrap return types of methods that use await into CompletableFuture automatically HOT 7
- How to use ea-sync in spring boot HOT 3
- java.lang.VerifyError is being thrown in specific case HOT 3
- Agent failed to start HOT 3
- Method references `Async::await` are not taken away HOT 1
- Problems with ea-async-maven-plugin
- How does ea-async process synchronized blocks?
- Java 14 Support? HOT 1
- What is the value of this? HOT 13
- Await in loops cause memory leak HOT 5
- Use with GWT
- the meaning of "executePhase" and "executeGoal" in plugin.xml ?
- Sounds like a good idea... HOT 5
- is this awesome project alive? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ea-async.