Use native open dialog? about electron HOT 6 CLOSED

Absolutely: native.

On Thursday, May 16, 2013, Corey Johnson wrote:

Should we use the native OS X open dialog instead of the Chromium one?
They look almost identical, but the behavior is different. You can move the
native open dialog around, but you can't do that with the chromium dialog.

Here is the chromium open dialog:

[image: skitch]https://f.cloud.github.com/assets/596/515587/6f24ae30-be7c-11e2-9882-2035b00499a7.jpg

And here is the native open dialog:

[image: menubar]https://f.cloud.github.com/assets/596/515590/89188f8c-be7c-11e2-83aa-fdb4717ae6ba.jpg

Should we try and keep the native open dialog behavior? /cc @nathansobohttps://github.com/nathansobo
@kevinsawicki https://github.com/kevinsawicki

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9
.

from electron.

The open dialog used by Chromium is in fact a native dialog too, it's just showed as sheet. The open dialog in other applications is in the same style with Atom, so I think it's right to keep Atom's behavior.

The dialog API is reusing Chromium's ui library so the open dialog just follows Chromium's one, I'll reimplement it to control the dialog's style completely.

btw, in Atom the save dialog is also showed as the same style with open dialog, however in most other applications (like Safari, TextEditor) the save dialog is showed as sheet, should we change the behavior of save dialog in Atom?

from electron.

I don't mind the sheet, but I think the functionality needs to be the same
otherwise to ensure maximum power.

On Friday, May 17, 2013, Cheng Zhao wrote:

The open dialog used by Chromium is in fact a native dialog too, it's just
showed as sheethttps://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/Sheets/Concepts/AboutSheets.html%23//apple_ref/doc/uid/20001043-BABFIBIA.
The open dialog in other applications is in the same style with Atom, so I
think it's right to keep Atom's behavior.

The dialog API is reusing Chromium's ui library so the open dialog just
follows Chromium's one, I'll reimplement it to control the dialog's style
completely.

btw, in Atom the save dialog is also showed as the same style with open
dialog, however in most other applications (like Safari, TextEditor) the
save dialog is shown as sheet, should we change the behavior of save dialog
in Atom?

[image: screen shot 2013-05-17 at 4 56 20 pm]https://f.cloud.github.com/assets/639601/517066/aae92fb0-becf-11e2-884d-6b1059832d8b.png

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-18050653
.

from electron.

Oh I was confused. If the only difference is that it's a sheet but its
otherwise the same, I don't think it matters.

On Friday, May 17, 2013, Nathan Sobo wrote:

I don't mind the sheet, but I think the functionality needs to be the same
otherwise to ensure maximum power.

On Friday, May 17, 2013, Cheng Zhao wrote:

The open dialog used by Chromium is in fact a native dialog too, it's
just showed as sheethttps://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/Sheets/Concepts/AboutSheets.html%23//apple_ref/doc/uid/20001043-BABFIBIA.
The open dialog in other applications is in the same style with Atom, so I
think it's right to keep Atom's behavior.

The dialog API is reusing Chromium's ui library so the open dialog just
follows Chromium's one, I'll reimplement it to control the dialog's style
completely.

btw, in Atom the save dialog is also showed as the same style with open
dialog, however in most other applications (like Safari, TextEditor) the
save dialog is shown as sheet, should we change the behavior of save dialog
in Atom?

[image: screen shot 2013-05-17 at 4 56 20 pm]https://f.cloud.github.com/assets/639601/517066/aae92fb0-becf-11e2-884d-6b1059832d8b.png

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-18050653
.

from electron.

These two types of dialogs have the the same functionality, and are of the save native type (NSOpenPanel), the only difference is how they are showed: [NSOpenPanel beginSheetModalForWindow] shows it as sheet, [NSOpenPanel runModal] shows it as the movable modal dialog.

In most other applications, open dialogs are showed as movable modal dialog, and save dialogs are showed as sheet. In Atom, both are showed as movable modal dialogs. In Atom Shell and Chromium, both are showed as sheets.

So I think we should follow how most of other Cocoa applications did?

from electron.

I'd say it's not a high priority to make them moveable. If it would be a 30
minute fix I'd do it, otherwise I think we should focus on higher
priority issues and leave the dialog stuff for later.

On Friday, May 17, 2013, Cheng Zhao wrote:

These two types of dialogs have the the same functionality, and are of the
save native type (NSOpenPanel), the only difference is how they are showed: [NSOpenPanel
beginSheetModalForWindow] shows it as sheet, [NSOpenPanel runModal] shows
it as the movable modal dialog.

In most other applications, open dialogs are showed as movable modal
dialog, and save dialogs are showed as sheet. In Atom, both are showed as
movable modal dialogs. In Atom Shell and Chromium, both are showed as
sheets.

So I think we should follow how most of other Cocoa applications did?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-18070050
.

from electron.