Comments (13)
As with #9, current API follows Chromium's ui library, I'll reimplement the API along with changing the interface.
from electron.
I'm now implementing the file dialog API for Windows, but the problem is: the standard Windows file dialog does not support selecting both files and directories, and there is no way to select multiple directories too. The same limitation exists in GTK+, so we would face the same problem when porting atom-shell on Linux.
The only solution is to create custom file dialogs, but the work would be quite large, and it's very hard to make them behave similar to the standard ones. So I think maybe we should just separate the open of files from directories in Atom?
/cc @probablycorey @kevinsawicki @nathansobo
from electron.
@xpaulbettsx any advice on this? I'd love to keep the current behavior if we can.
from electron.
@nathansobo As @zcbenz says, Windows and GTK+ aren't down with a file chooser picking both files and folders, it's either one or the other. What scenario do you need to pick both? Windows >= Vista does allow you to pick multiple directories afaik
from electron.
Does this mean you can't open multiple files and directories at the same
time in Windows and GTK+. Or does this mean there is no dialog that lets
you open a file or a directory (one dialog only opens directories, and
another only opens files).
In OS X it is very common to use the same dialog to open either a single
file or a single directory. So I think we need that functionality.
On Fri, Aug 2, 2013 at 10:59 AM, Paul Betts [email protected]:
@nathansobo https://github.com/nathansobo As @zcbenzhttps://github.com/zcbenzsays, Windows and GTK+ aren't down with a file chooser picking both files
and folders, it's either one or the other. What scenario do you need to
pick both? Windows >= Vista does allow you to pick multiple directories
afaik—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-22022617
.
from electron.
Does this mean you can't open multiple files and directories at the same time in Windows and GTK+
Exactly
In OS X it is very common to use the same dialog to open either a single file or a single directory
That part's fine
from electron.
Ok, cool. I think it's fine if we can't open multiple files and directories
at the same time in OS X.
On Mon, Aug 5, 2013 at 11:03 AM, Paul Betts [email protected]:
Does this mean you can't open multiple files and directories at the same
time in Windows and GTK+Exactly
In OS X it is very common to use the same dialog to open either a single
file or a single directoryThat part's fine
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-22124534
.
from electron.
@xpaulbettsx do you mean that it's possible to use the same dialog to select either file or folder on Windows with Win32 API? Where can I find the related documentation or example?
from electron.
@zcbenz Sure, check out http://msdn.microsoft.com/en-us/library/windows/desktop/bb776913(v=vs.85).aspx - afaik it's simply a matter of including / not including FOS_PICKFOLDERS
Also, this code is not nearly as ugly as it looks, the Explorer team bans more than one return statement in a method, because they love code that looks like this:
}
}
delete bar;
}
}
}
}
from electron.
@xpaulbettsx Thanks for the link!
So on Windows we could support following dialogs:
- dialog to open single/multiple files
- dialog to open single folder
- dialog to open multiple folders (only on Windows >= Vista)
- dialog to open single file or folder (only on Windows >= Vista)
@nathansobo @probablycorey Is it OK to discard Windows XP for Atom?
from electron.
Is it OK to discard Windows XP for Atom?
Please don't launch with XP support, it's a twelve-year old operating system. We don't support OS X 10.1 either, despite it actually being a month younger than Windows XP.
from electron.
@zcbenz I'd be happy to support Windows >= Vista.
On Tue, Aug 6, 2013 at 5:18 AM, Paul Betts [email protected] wrote:
Is it OK to discard Windows XP for Atom?
Please don't launch with XP support, it's a twelve-year old operating
system. We don't support OS X 10.1http://en.wikipedia.org/wiki/Mac_OS_X_v10.1despite it actually being a month younger than Windows XP.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-22174685
.
from electron.
Close this for favor of #76.
from electron.
Related Issues (20)
- [Bug]: Clicking on the color picker doesn't do anything HOT 4
- [Bug]: New Protocol.handle vs Protocol.registerFileProtocol does not fetch files properly.
- [Bug]: Crash base::subtle::RefCountedBase::ReleaseImpl() EXCEPTION_ACCESS_VIOLATION_READ HOT 1
- [Bug]: Capturing the screen is broken in the newer version (desktopCapturer) HOT 2
- gitHub.com/docker/repo
- [Feature Request]: add config.hideDock to BrowserWindow.setHiddenInMissionControl
- [Bug]: Calling session.defaultSession.webRequest.onHeadersReceived after ready and before window creation causes silent crash
- webContents.getPrintersAsync() not returning printer list on Linux Mint Cinnamon 19.1 HOT 3
- [Bug]: Frameless BrowserView.setAutoResize() is broken in v30.0.1
- [Infra]: Test check CI failed to execute because of npm package not found HOT 3
- [Bug]: <input type="file"> is not showing dialog on click HOT 7
- [Bug]: app.setLoginItemSettings({ openAtLogin: true }) doesnt work in APPX after publishing it.
- [Bug]: <input type=file> not working in WebContentsView HOT 1
- [Bug]: Occasional segfault when closing window on Linux
- stop removing tags from your repo HOT 12
- [Bug]: `screen.getAllDisplays()` and `desktopCapturer.getSources()` order no longer matches (29.3.2, 30.0.2)
- [Bug]: `desktopCapturer` thumbnails not respecting `thumbnailSize`, always low-res (29.3.2)
- [Bug]: Calling preventDefault on BrowserWindow close event still destroys BrowserViews' webContents
- [Feature Request]: Support webp format in NativeImage class [totoWEBP()]
- [Bug]: `fs.readdir` does not work correctly with files that contain umlauts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron.