Git Product home page Git Product logo

Comments (7)

MarshallOfSound avatar MarshallOfSound commented on June 15, 2024

@deadcoder0904 From the sounds of it you jumped into Electron Forge v6 (the version that is currently being built and is still in beta) and then tried to use stuff that hasn't been set up yet.

For instance, this templates repository hasn't been migrated to use v6 and v6 doesn't have real support for templates yet.

See the Giant Warning on the electron-forge README.

from electron-forge-templates.

MarshallOfSound avatar MarshallOfSound commented on June 15, 2024

RE auto updating dependencies, green keeper has historically annoyed me more than it has helped. The v6 rewrite of templates won't be framework specific anyway, rather build tool templates that you can then use with whatever framework you want.

E.g. There would be a webpack template and a parcel template, we may have examples for popular frameworks like React but the ethos of templates will change with v6 to be less opinionated and more helpful 👍

from electron-forge-templates.

deadcoder0904 avatar deadcoder0904 commented on June 15, 2024

Nice awesome. Okay I will try v5 of electron-forge & see if it works ;)

I actually tried v6 because you know nowadays every beta version is stable (React, RN, Electron, etc.)😂 & also docs are looking better

from electron-forge-templates.

MarshallOfSound avatar MarshallOfSound commented on June 15, 2024

Electron

Uh, be warned, Electron Beta is explicitly called beta. It's not "stable" out of the gate, we have these beta cycles to fix new crashes and bugs that appear. Beta 100% means beta 😄

from electron-forge-templates.

deadcoder0904 avatar deadcoder0904 commented on June 15, 2024

So I tried v5 & it works out of the box, thank you. But, eslint is shouting.

Also, I guess most people prefer .js as an extension for React rather than .jsx. So I did this for that. Can you make it default❓

Also, it might be a good idea to make Prettier a default or either an opt-in. What do you think❓

from electron-forge-templates.

MarshallOfSound avatar MarshallOfSound commented on June 15, 2024

It's worth noting that Electron Forge's templates were never intended to be boilerplates. In fact that's something I steered well clear of, boilerplates are over architected, over opinionated massive piles of code that normally makes no sense to anyone.

To this end in v6 the default linting setup (eslint / standard / whatever) has been removed from forge. We want to let users do whatever they want to do easily, but also not make choices for them. If you don't want to use prettier, don't... If you want to use .js instead of .jsx, that's fine, go for it.

The goal of v6 was to empower users to do whatever they want, and be less opinionated by default. See the plugin system and such for examples of this effort.

TLDR: Linting is not part of core forge anymore, so making changes to these templates for things like eslint configs or adding prettier make little sense

from electron-forge-templates.

deadcoder0904 avatar deadcoder0904 commented on June 15, 2024

Nice amazing. Okay one last question, my JSX isn't getting code-highlighting❓

Any ETA on v6 release like a month or 6 months❓

from electron-forge-templates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.