Comments (3)
So, the fundamental principle of the "low-level" client is that it doesn't "touch" the body, either for request in response; this is for multiple reasons:
- To provide as much performance as possible, the body is not parsed, and only passed around as an
io.Reader
, and handling the body is left to the calling code. - To allow using any third-party JSON package, without declaring some kind of contract it has to implement.
Most responses in Elasticsearch will have at least a top-level predictable response structure.
That's a pretty brave statement :) In fact, Elasticsearch has quite a lot of completely different response structures, not only for different APIs, but also within a single API, like Search.
As of now, there is no formal specification of the request and response body structures — as we have for the API "surface" —, making it impractical (or impossible) to provide a reliable and maintainable implementation of the structure. (The maintainability of the olivere/elasticsearch
Go package and the NEST client suffers due to this fact.)
With that in mind, you absolutely don't have to "define response type structs all over the place".
First of all, the package implements the String()
method for responses, which makes it possible to pass it eg to fmt.Println
, as you see in the README examples, in order to make one of the obvious use cases ("I want to see the response") as easy as possible. (There's also a built-in logging with multiple formats for that.)
Second, when it comes to the request body, the library provides a helper, esutil.JSONReader
, so you can pass a custom struct with a document, or a map[string]interface{}
with a query, to the client without messing around with conversion to io.Reader
.
Third, in many cases, it's impractical to define the full representation of the Elasticsearch response, because you're interested only in specific parts. For this, the tidwall/gjson
package is very convenient — and much faster.
Have you seen the examples in _examples/encoding
? They may provide some inspiration about different approaches to decoding the response bodies.
from go-elasticsearch.
Hello, any news here?
from go-elasticsearch.
Hi @jordansissel, closing for now, please re-open if you want to discuss the topic more?
from go-elasticsearch.
Related Issues (20)
- Trying Sort by Script. Kibana worked but GoLang failed on JSON parsing, "_script" HOT 3
- Trying Sort by Script. Kibana worked but GoLang failed on JSON parsing, "_script" HOT 1
- mdsc certificate is not truested HOT 3
- Unstructured multisearch response HOT 1
- pull message from broker error HOT 1
- Elasticsearch new template version support HOT 2
- How to let then client reuse http connection? HOT 1
- Connect to Elasticsearch from AWS HOT 3
- Scrolling with typedclient API HOT 2
- Is it safe to use multiple BulkIndexers concurrently? HOT 2
- BulkIndexer WaitGroup delta is added after workers are launched
- Aggregation alias (`aggs`) is not handled in generated Go code HOT 4
- [Request feedback] Looking for feedback about the UX experience
- TypedClient: Search parameters "size" and "from" seem to be ignored HOT 1
- Reset方法不存在
- typedapi.core.search.Request does not have filter_path HOT 2
- Request parsing of terms query not working as expected HOT 3
- All my request get EOF error.
- The ctx timeout is not set in the DiscoverNodes request. Users should be able to customize the timeout.
- [knn] queries cannot be provided directly, use the [_knn_search] endpoint instead
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-elasticsearch.