Git Product home page Git Product logo

Comments (6)

ivancea avatar ivancea commented on July 20, 2024 1

Related with #100634
I'm closing as duplicate. It's not exactly the same issue I think, but it's part of it for sure

from elasticsearch.

alex-spies avatar alex-spies commented on July 20, 2024 1

median(const) is already implemented, while percentile still needs a corresponding MV_... function to act as surrogate.

Not sure it's worth adding a validation for this, as implementing something like MV_PERCENTILE (but not exposing it to users, internal usage only) may not be a whole lot more work.

from elasticsearch.

elasticsearchmachine avatar elasticsearchmachine commented on July 20, 2024

Pinging @elastic/es-analytical-engine (Team:Analytics)

from elasticsearch.

luigidellaquila avatar luigidellaquila commented on July 20, 2024

I'm not sure we should close this, #100634 is a request for enhancements while this one is an actual bug (error 500).
Waiting for #100634 to be fully supported, we should at least add some validation for these cases.

Interestingly, median(null) works just fine, while percentile(null, 50) throws an error

from elasticsearch.

ivancea avatar ivancea commented on July 20, 2024

I'm 50/50 here really. The aggs that don't fail, is because they have the surrogate, indeed. However, any agg with multiple parameters, that have a null in one of them but a non-foldable in the other, will fail.

For example, percentile can't really be fixed. We can't convert PERCENTILE(field, null) to MV_PERCENTILE, as field is not foldable (At least not with the current methods, afaik). And it fails too.

So, we can reopen this if you think it's interesting

from elasticsearch.

alex-spies avatar alex-spies commented on July 20, 2024

Ah, I was thinking about percentile(null, 50), but this is indeed a different problem than percentile(some_field, null). The latter indeed should end up with an error thrown at validation time.

Re-opening, but I think we need to make the wording of this issue more precise.

from elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.