Git Product home page Git Product logo

Comments (6)

benwtrent avatar benwtrent commented on July 1, 2024 1

@mayya-sharipova I think using index.max_regex_length is a good idea. Default of 1k is prudent.

from elasticsearch.

elasticsearchmachine avatar elasticsearchmachine commented on July 1, 2024

Pinging @elastic/es-search (Team:Search)

from elasticsearch.

YahelyUshpiz avatar YahelyUshpiz commented on July 1, 2024

working on it

from elasticsearch.

benwtrent avatar benwtrent commented on July 1, 2024

We need to determine what a "huge value" means.

Additionally, I am not 100% sure we want to simply disable this for all users. If we blindly reject query prefixes we think are "large", it would break existing behavior (e.g. user's who expect a query to work now has their query always fail with no recourse).

Maybe there should be a setting indicating the allowed prefix size or if "large" prefixes are allowed?

We cannot use the setting search.allow_expensive_queries to indicate if large prefixes are allowed or not, as its already used to determine if prefix queries themselves are allowed.

from elasticsearch.

mayya-sharipova avatar mayya-sharipova commented on July 1, 2024

It is reasonable to have a limit of 1000.

I suggest we reuse the setting index.max_regex_length and update the documentation saying that this setting also applies to prefix queries (and may be also wildcard queries?).

@benwtrent What do you think?

from elasticsearch.

arshPratap avatar arshPratap commented on July 1, 2024

Hi @mayya-sharipova @benwtrent .. if this issue is open can this be assigned to me. I would love to contribute to elasticsearch
Thanks
Arsh Pratap

from elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.