Git Product home page Git Product logo

Comments (5)

elasticsearchmachine avatar elasticsearchmachine commented on July 20, 2024

Pinging @elastic/es-core-infra (Team:Core/Infra)

from elasticsearch.

pgomulka avatar pgomulka commented on July 20, 2024

this test is failing because of search.threads.queue.size being different in threadpool stats and metric.


[0006-05-03T15:16:51,033][INFO ][o.e.t.SimpleThreadPoolIT ] [testThreadPoolMetrics] Stats of `search`: {search.threads.active.current=0, search.threads.completed.total=475, search.threads.count.current=7, search.threads.largest.current=7, search.threads.queue.size=1} |  
-- | --
  | [0006-05-03T15:16:51,033][INFO ][o.e.t.SimpleThreadPoolIT ] [testThreadPoolMetrics] Measurements of `search`: {search.threads.active.current=[0], search.threads.completed.total=[476], search.threads.count.current=[7], search.threads.largest.current=[7], search.threads.queue.size=[0]}

we are waiting for the threadpool stats to report that there is no active thread. A line later we collect metric measurments.
I suspect that in that moment there might be a new thread submitted hence the threadpool stat is reporting 0, when the metric mesurment is reporting 1.

@mosche wdyt? you worked on hardening this test before

from elasticsearch.

pgomulka avatar pgomulka commented on July 20, 2024

I wonder if there is a way to reliably and gently shutdown a threadpool or EsIntegTest so that we have a 'frozen' es node that we can assert about

from elasticsearch.

mosche avatar mosche commented on July 20, 2024

I see a few options:

  • limit the test to thread pools for which we don't expect scheduled background threads to remove the indeterminism.
  • extend the check in line 155 to make sure active = 0 & queue = 0, that way anything gathered in measurements later can only be greater or equals ... but then it's somehow pointless to even check active and queued and we could simply remove these.
  • alternatively we could block & completely fill the thread pool the same way you've done in the kibana thread pool test. though that almost seems to be unnecessarily complex for what we'd like to test

from elasticsearch.

pgomulka avatar pgomulka commented on July 20, 2024

test is failing due to threadpool stats vs apm metric discrepancy. most likely a timing issue
assesing the risk to low

from elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.