Git Product home page Git Product logo

Comments (3)

kkrik-es avatar kkrik-es commented on July 19, 2024 1

@lkts wanna take a look at hardening ScaledFloatFieldMapper#decodeForSyntheticSource and updating the test as described above?

from elasticsearch.

elasticsearchmachine avatar elasticsearchmachine commented on July 19, 2024

Pinging @elastic/es-storage-engine (Team:StorageEngine)

from elasticsearch.

martijnvg avatar martijnvg commented on July 19, 2024

The reason that the assertion trips is that in ScaledFloatFieldMapper#decodeForSyntheticSource(...) method scaledValue / scalingFactor expression results into negative infinity. Then when v += Math.ulp(v) is executed, v variable becomes NaN. The assertion fails, because it can't recompute the scaledValue (which is -77).

In this case the scalingFactor is 4.275522857276975E-307. Using such tiny scaling factors are likely going to produce infinity as a result. In the context of synthetic source, synthesizing the original value or an equivalent isn't possible. Either the test should be adjust to use values that are Math.floor(value) != 0.0d or the ScaledFloatFieldMapper#decodeForSyntheticSource(...) should be adjust to not attempt adjusting the value if scaledValue / scalingFactor results into infinity.

from elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.