Comments (7)
PeeHaa
commented on August 29, 2024
@ekinhbayar could you add the repo to scrutinizer and travis in preparation of above please?
from gitamp.
ekinhbayar
commented on August 29, 2024
Done. Also made a head start for missing tests on unit-tests branch but still unsure about the Storage one I have there.
from gitamp.
ekinhbayar
commented on August 29, 2024
Scrutinizer has a CS checker in place. I think I haven't added CS checks to Travis CI anywhere yet.
Also I added the mention-bot webhook in repo settings, not sure if I need to anything else than that, it's only watching new PR's @PeeHaa.
from gitamp.
PeeHaa
commented on August 29, 2024
All tests are written. Pretty sure the RedisCounter is also covered.
I have opened an issue on the code-coverage repo sebastianbergmann/php-code-coverage#501
from gitamp.
PeeHaa
commented on August 29, 2024
It looks like there is/was an issue with function imports. Using fqn fixed the code coverage 174b22b.
It looks like the latest code-coverage release will fix the issue, but it's changelog is... uhhhmm.. not helpful at all.
from gitamp.
PeeHaa
commented on August 29, 2024
Updating the dependencies indeed fixed the coverage issue we were seeing. So this is fixed in 9e7d3ef
from gitamp.
PeeHaa
commented on August 29, 2024
Closing this issue for now, because I am annoyed by the issue hanging on a single thing.
If we want to try to add the cs fixer in the future again just open a new issue for it.
from gitamp.
Related Issues (20)
- Hide event queue count
- Upstream DNSLIB problems HOT 8
- Prevent horizontal scroll on mobile HOT 1
- Allow different event sources HOT 1
- Remove the tight coupling of the Results class
- Properly handle connection errors HOT 2
- Implement a logger
- gitamp.service does not auto-restart on reboot HOT 1
- Fix log levels
- Make log level a config option
- Prevent scriptkiddies from breaking our glorious project HOT 1
- Something is leaky HOT 1
- Install ext/uv
- Add tooling to force and check for fqn function calls HOT 2
- Improve redis counter API HOT 2
- Minify resources
- v2_rewrite HOT 10
- Todo for stable HOT 1
- Toggle between two modes HOT 1
- Bump min PHP version to ^8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitamp.