Git Product home page Git Product logo

Comments (17)

pannal avatar pannal commented on June 17, 2024

I think this is related: audiorouterdev/audio-router#24

from synchronousaudiorouter.

eiz avatar eiz commented on June 17, 2024

Not sure if related. SAR uses a very different method of overriding the default audio device than audio-router, but it's plausible that some anti-cheat software could break it. I don't have a copy of the game and haven't tested it.

Mind checking its handle list using Process Explorer? See if you see SarAsio.dll in its list of open files.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Yes it is (SarAsio_x64.dll).

from synchronousaudiorouter.

stkfd avatar stkfd commented on June 17, 2024

@pannal, you were saying you added the Battle.net folder to the SAR applications; could you share the exact expression you used? Adding whole folders only works by adding a regular expression that matches everything in it, maybe something went wrong with that expression.

I wrote that guide by the way ;)

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Sure, but the regex is correct, as Hearthstone and other Battle.net games work in SAR.
I was so desperate at one point, because I thought my regex was wrong, that I ended up using .+GAMES.+, which is the root folder for Steam and Battle.net.

from synchronousaudiorouter.

eiz avatar eiz commented on June 17, 2024

This appears to have nothing to do with Overwatch specifically. The problem is that Overwatch is using the XAudio2 API, which appears to have some backdoor way of getting the default audio device. It only calls IMMDeviceEnumerator::GetDevice, never IMMDeviceEnumerator::GetDefaultAudioEndpoint. Same problem happens with the basic playback example from the XAudio2 SDK samples. I'll see if I can find a solution.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Awesome. I love the work you're doing here. Any news on a new beta?

from synchronousaudiorouter.

eiz avatar eiz commented on June 17, 2024

Need to complete a few bug fixes first. Kind of slow going atm due to work related reasons.

I'm taking a closer look now and it appears that XAudio2 is creating its renderer by calling ActivateAudioInterfaceAsync with DEVINTERFACE_AUDIO_RENDER, which goes straight into MMDevAPI's internal endpoint lookup code. ActivateAudioInterfaceAsync is implemented by an undocumented coclass ActivateAudioInterfaceWorker (E2F7A62A-862B-40AE-BBC2-5C0CA9A5B7E1) which could be intercepted, albeit at the cost of introducing a dependency on an undocumented interface. Going to give it a shot.

For completeness, other options would include hijacking the export out of MMDevAPI (very intrusive) or hijacking the top level XAudio2 COM interface (less comprehensive, other code that uses ActivateAudioInterfaceAsync wouldn't be covered). I consider CreateRemoteThread type approaches (e.g. used by audiorouter) off the table.

from synchronousaudiorouter.

eiz avatar eiz commented on June 17, 2024

This is now fixed in master. Doing some more local testing and will get a package up soon.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

You're the best. Do you have DEV instructions laying around somewhere for me to follow? I could test the latest master by myself.

I'm a developer myself (although, more Python-focused), so I should get through it.

Something like: install these requirements, build using that toolchain, sign with test key, fire away.

from synchronousaudiorouter.

eiz avatar eiz commented on June 17, 2024

Here is a build. This is not adequately tested for release. Should your machine catch fire, don't say I didn't warn you.

SynchronousAudioRouter_x64_0_13_debug_20170417.zip

Notes:

  • Not tested on anything but win10 x64
  • Contains a SAR NDIS driver for future networking support. Currently does nothing, should be harmless, but ymmv
  • There's significant changes to the installer
  • Debug logging is on, make sure your %APPDATA%\SynchronousAudioRouter\logs doesn't fill with too much spam
  • Seriously, if it bugchecks, don't be surprised, I haven't even run this under Driver Verifier yet.

I don't have actual development instructions, but basically you need VS 2015 with all the C++ and ATL/COM stuff installed, the Windows Driver Kit, and WiX 3.10. Build defaults to test signing which you can Google how to enable loading test signed drivers. Debugging is best done with a 2 machine setup (I use a pair of Firewire cards for 1394 debugging).

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

I'll try it, haven't had the time yet, sorry.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Works. Also I don't have to quit reaper before going into sleep with the newest release (resulted in a bugcheck bluescreen).

Seems to work well for now.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Yep, runs well.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Ok, no issues since 3 days. Runs well, works with all games yet, and survives standby.

Great job!

from synchronousaudiorouter.

eiz avatar eiz commented on June 17, 2024

Thanks for the feedback. I assume you were hitting the registry filter bugcheck I fixed. IRQL_NOT_LESS_OR_EQUAL or something to that effect?

Edit: actually I'm not sure you could have ever hit that. Do you have any files in C:\Windows\Minidump with the crash info? I could use that for verification purposes.

from synchronousaudiorouter.

pannal avatar pannal commented on June 17, 2024

Exactly. I had to stop reaper before letting my PC go to standby before, otherwise I'd get exactly that bugcheck.

Edit: I had, yes. But that got cleaned up on the last cleanup run, I'm sorry.

from synchronousaudiorouter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.